I have been working long on upgrading/bug fixing stylesheets.
And since I have not encountered any big bugs past weeks I think it's ready to be implemented.
I have replaced the light/dark/darker stylesheets and added a dark-modern and a light-modern.
I also added a dark preference pack and a light preference pack.
I do think I need some help with setting it up, since I compiled my branch and the new stylesheets didn't show up. Hopefully @chennes has some time to help.
https://github.com/FreeCAD/FreeCAD/pull/9715
New stylesheets + preference packs #9715
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Be nice to others! Respect the FreeCAD code of conduct!
- MisterMaker
- Posts: 744
- Joined: Mon Sep 21, 2020 7:41 am
- Contact:
New stylesheets + preference packs #9715
Last edited by MisterMaker on Mon Jun 05, 2023 6:06 pm, edited 1 time in total.
- adrianinsaval
- Veteran
- Posts: 5551
- Joined: Thu Apr 05, 2018 5:15 pm
Re: New stylesheets + preference packs
I suspect you didn't add the new files to cmake so they get installed
- MisterMaker
- Posts: 744
- Joined: Mon Sep 21, 2020 7:41 am
- Contact:
Re: New stylesheets + preference packs
That was it, I'm total noob in this but I updated it tested it and turned my pr into a full PR.adrianinsaval wrote: ↑Sun Jun 04, 2023 10:09 pm I suspect you didn't add the new files to cmake so they get installed
- MisterMaker
- Posts: 744
- Joined: Mon Sep 21, 2020 7:41 am
- Contact:
Re: New stylesheets + preference packs
Had some issues with .gitignore Github desktop seemed to overwrite the one in the Freecad repro and it got in my PR.
It's now fixed, I added CMakePresets.json since that is where my cmake settings are. I guess I am the only one compiling on Visual studio code?
It's now fixed, I added CMakePresets.json since that is where my cmake settings are. I guess I am the only one compiling on Visual studio code?
- MisterMaker
- Posts: 744
- Joined: Mon Sep 21, 2020 7:41 am
- Contact:
Re: New stylesheets + preference packs #9715
I have no idea what this means:
https://github.com/FreeCAD/FreeCAD/pull ... 1596109139
Is it so that it is planned for future release?
https://github.com/FreeCAD/FreeCAD/pull ... 1596109139
Is it so that it is planned for future release?
- adrianinsaval
- Veteran
- Posts: 5551
- Joined: Thu Apr 05, 2018 5:15 pm
Re: New stylesheets + preference packs #9715
no that's just a bot comment stating the status of the CI checks that were done on gitlab (this has been disabled now), don't mind it.MisterMaker wrote: ↑Fri Jun 30, 2023 7:24 pm I have no idea what this means:
https://github.com/FreeCAD/FreeCAD/pull ... 1596109139
Is it so that it is planned for future release?