(solved) OCCT7.7.1 create view bug with links and PartContainer (master)

Discussions about the development of the TechDraw workbench
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
user1234
Veteran
Posts: 3345
Joined: Mon Jul 11, 2016 5:08 pm

(solved) OCCT7.7.1 create view bug with links and PartContainer (master)

Post by user1234 »

I found a really nasty bug, which takes me way way too long, that i found he reason (not the real source), that the OCCT version is the reason.

Open the attachment, it contains

- mwe_original.FCStd
- mwe_link.FCStd

- open the file mwe_link.FCStd file, it automatic opens the mwe_original.FCStd file
- make sure, that the mwe_original.FCStd file is completely loaded (that the file symbol in the tree is not gray)
- open the Page in mwe_link.FCStd and the TechDrawWB
- create a View (or Projection Group View, it does not matter) of the linked Body in the linked PartContainer
- works in OCCT7.6.3 and OCCT7.7.1
- delete the View
- create a View (or Projection Group View, it does not matter) of the linked PartContainer
- works in OCCT7.6.3 and does not OCCT7.7.1

error message:

Code: Select all

<Exception> gp_GTrsf::Trsf() - non-orthogonal GTrsf

tested with:

Code: Select all

OS: Debian GNU/Linux 11 (bullseye) (X-Cinnamon/lightdm-xsession)
Word size of FreeCAD: 64-bit
Version: 0.21.0.32840 (Git)
Build type: Release
Branch: master
Hash: 5533e06466c732381f42b3ef7aabc086455b422f
Python 3.9.2, Qt 5.15.2, Coin 4.0.0, Vtk 9.0.1, OCC 7.6.3
Locale: English/United States (en_US)
Installed mods: 
  * QuickMeasure 2022.10.28
  * Assembly4 0.12.6
  * CurvedShapes 1.0.4
  * Curves 0.6.8
occt7.6.3.png
occt7.6.3.png (192.61 KiB) Viewed 1379 times


Code: Select all

OS: Debian GNU/Linux 11 (bullseye) (X-Cinnamon/lightdm-xsession)
Word size of FreeCAD: 64-bit
Version: 0.21.0.32840 (Git)
Build type: Release
Branch: master
Hash: 5533e06466c732381f42b3ef7aabc086455b422f
Python 3.9.2, Qt 5.15.2, Coin 4.0.0, Vtk 9.0.1, OCC 7.7.1
Locale: English/United States (en_US)
Installed mods: 
  * QuickMeasure 2022.10.28
  * Assembly4 0.12.6
  * CurvedShapes 1.0.4
  * Curves 0.6.8
occt7.7.1.png
occt7.7.1.png (181.18 KiB) Viewed 1379 times



Greetings
user1234
Attachments
mwe.zip
(22.97 KiB) Downloaded 32 times
Last edited by user1234 on Tue May 09, 2023 10:58 am, edited 1 time in total.
User avatar
adrianinsaval
Veteran
Posts: 5541
Joined: Thu Apr 05, 2018 5:15 pm

Re: OCCT7.7.1 create view bug with links and PartContainer (master)

Post by adrianinsaval »

are you using blobfish fork of occt? please create a github issue for this if it's still reproducible

@tanderson69 do you perhaps know what is different here between 7.6.3 and 7.7.1?
user1234
Veteran
Posts: 3345
Joined: Mon Jul 11, 2016 5:08 pm

Re: OCCT7.7.1 create view bug with links and PartContainer (master)

Post by user1234 »

adrianinsaval wrote: Tue May 02, 2023 8:50 pm are you using blobfish fork of occt?
What means blobfish in git context? It is a self compield OCCT from the 7.7.1 head with the 7.7.1 tag commit. Installed on Debian with default structure/path.

https://git.dev.opencascade.org/gitweb/ ... ags/V7_7_1


adrianinsaval wrote: Tue May 02, 2023 8:50 pm please create a github issue for this if it's still reproducible
I have no access to gh atm. The issue still exists.


Greetings
user1234
User avatar
adrianinsaval
Veteran
Posts: 5541
Joined: Thu Apr 05, 2018 5:15 pm

Re: OCCT7.7.1 create view bug with links and PartContainer (master)

Post by adrianinsaval »

user1234 wrote: Tue May 02, 2023 9:03 pm What means blobfish in git context? It is a self compield OCCT from the 7.7.1 head with the 7.7.1 tag commit. Installed on Debian with default structure/path.
blobfish is an username: https://gitlab.com/blobfish/occt
we use his fork for most of our release binaries (if not all), he is here as @tanderson69
Syres
Veteran
Posts: 2893
Joined: Thu Aug 09, 2018 11:14 am

Re: OCCT7.7.1 create view bug with links and PartContainer (master)

Post by Syres »

@user1234 just to be absolutely clear the change causing the regression came in the OCCT 7.7.0 dev cycle not the 7.7.1 dev cycle. I have a couple of old(ish) builds to prove this. The 7.6.3 build works as expected and the 7.7.0 build fails with the same error you quoted:

Code: Select all

OS: Linux Mint 20.3 (X-Cinnamon/cinnamon)
Word size of FreeCAD: 64-bit
Version: 0.21.0.32636 (Git)
Build type: Release
Branch: master
Hash: 9666aac669fc4d84985554bc7c3c61e3cdc2c7ab
Python 3.8.10, Qt 5.12.8, Coin 4.0.0, Vtk 7.1.1, OCC 7.7.0
Locale: English/United Kingdom (en_GB)
Installed mods: 
  * Silk 1.0.0
  * A2plus
  * Defeaturing 1.2.0
  * CurvedShapes 1.0.4
  * MakerWorkbench 1.0.1
  * freecad.gears 1.0.0
  * Curves 0.6.8
  * toSketch 1.0.1
  * Plot 2022.4.17
  * AirPlaneDesign 0.4.0
  * fasteners 0.4.56
  * sheetmetal 0.2.63

Code: Select all

OS: Linux Mint 20.3 (X-Cinnamon/cinnamon)
Word size of FreeCAD: 64-bit
Version: 0.21.0.32636 (Git)
Build type: Release
Branch: master
Hash: 9666aac669fc4d84985554bc7c3c61e3cdc2c7ab
Python 3.8.10, Qt 5.12.8, Coin 4.0.0, Vtk 7.1.1, OCC 7.6.3
Locale: English/United Kingdom (en_GB)
Installed mods: 
  * Silk 1.0.0
  * A2plus
  * Defeaturing 1.2.0
  * CurvedShapes 1.0.4
  * MakerWorkbench 1.0.1
  * freecad.gears 1.0.0
  * Curves 0.6.8
  * toSketch 1.0.1
  * Plot 2022.4.17
  * AirPlaneDesign 0.4.0
  * fasteners 0.4.56
  * sheetmetal 0.2.63
Syres
Veteran
Posts: 2893
Joined: Thu Aug 09, 2018 11:14 am

Re: OCCT7.7.1 create view bug with links and PartContainer (master)

Post by Syres »

The only way to be certain is to attempt a git bisect of the 7.7.0 source between 22nd July 2022 (7.6.3 release) and 7.7.0 release on 11th Nov 2022.
Syres
Veteran
Posts: 2893
Joined: Thu Aug 09, 2018 11:14 am

Re: OCCT7.7.1 create view bug with links and PartContainer (master)

Post by Syres »

I'm going to do a complete fresh build based on this https://git.dev.opencascade.org/gitweb/ ... 320de72ea6 to make sure I'm not going down a a rabbit hole but it looks on first pass that the very first commit after 7.6.3 was released caused this regression.

But, and it's a big one, have a look at the description Upgrade DRAW function XGetProperties to work with all document labels or sequence of labels , could it be that it's the way the labels of Link items isn't what OpenCascade would view as 'correct'??? When the XSource of the linked Body and the linked Part are looked up in the View, there's no consistency but that might well be by design.

I'll report back when the fresh build has finished.
user1234
Veteran
Posts: 3345
Joined: Mon Jul 11, 2016 5:08 pm

Re: OCCT7.7.1 create view bug with links and PartContainer (master)

Post by user1234 »

Syres wrote: Wed May 03, 2023 8:49 am just to be absolutely clear the change causing the regression came in the OCCT 7.7.0 dev cycle not the 7.7.1 dev cycle.
Can be, i never was able to compile 7.7.0, because of cmake regressions (there are still some, but was able to work around them).


Greetings
user1234
Syres
Veteran
Posts: 2893
Joined: Thu Aug 09, 2018 11:14 am

Re: OCCT7.7.1 create view bug with links and PartContainer (master)

Post by Syres »

Well I cannot compile FC using that specific OCCT commit so unable to prove categorically it's responsible, sorry. I might be able to assist with the trigger in DrawViewPart.cpp.
User avatar
tanderson69
Veteran
Posts: 1626
Joined: Thu Feb 18, 2010 1:07 am

Re: OCCT7.7.1 create view bug with links and PartContainer (master)

Post by tanderson69 »

adrianinsaval wrote: Tue May 02, 2023 8:50 pm @tanderson69 do you perhaps know what is different here between 7.6.3 and 7.7.1?
No idea. Too many unknowns.
Post Reply