PR making drilling paths G98 / G99 compatible with NIST std.

Here's the place for discussion related to CAM/CNC and the development of the Path module.
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Post Reply
User avatar
freman
Veteran
Posts: 2201
Joined: Tue Nov 27, 2018 10:30 pm

PR making drilling paths G98 / G99 compatible with NIST std.

Post by freman »

After having trashed one too many jobs and broken on too many tools, I got motivated to fix the G98 plays like G99 fudge.

https://github.com/FreeCAD/FreeCAD/pull/9153

It adds new keepToolDown property to UI ( as proposed by wsk8 ) and provides both G98 ( respecting retract to safeheight ) and G99 retracting to R value, (similar to existing drilling behaviour).

Hopefully this fits all needs and finally makes this NIST compliant .

Does what I need :)
Attachments
3d-KTD-view.png
3d-KTD-view.png (32.27 KiB) Viewed 722 times
trashed-tool.jpeg
trashed-tool.jpeg (118.05 KiB) Viewed 729 times
3d-view.png
3d-view.png (31.45 KiB) Viewed 730 times
Last edited by freman on Sat Apr 01, 2023 3:23 pm, edited 1 time in total.
GeneFC
Veteran
Posts: 5373
Joined: Sat Mar 19, 2016 3:36 pm
Location: Punta Gorda, FL

Re: PR making drilling paths G98 / G99 compatible with NIST std.

Post by GeneFC »

freman wrote: Sat Apr 01, 2023 1:10 pm
Comment made in github.

Gene
User avatar
freman
Veteran
Posts: 2201
Joined: Tue Nov 27, 2018 10:30 pm

Re: PR making drilling paths G98 / G99 compatible with NIST std.

Post by freman »

Thanks for taking a look. Apart from that critique, does it fit the bill?
GeneFC
Veteran
Posts: 5373
Joined: Sat Mar 19, 2016 3:36 pm
Location: Punta Gorda, FL

Re: PR making drilling paths G98 / G99 compatible with NIST std.

Post by GeneFC »

freman wrote: Sat Apr 01, 2023 5:44 pm Thanks for taking a look. Apart from that critique, does it fit the bill?
I did not try to test. The concept seems OK, but of course the devil is in the details. :shock:

I fully support the idea of trying to adhere to industry standards instead of bending the code to meet some user's particular problem of the day. I believe that drilling, more than anything else in the Path WB, has suffered from "private" tweaks.

Gene
User avatar
freman
Veteran
Posts: 2201
Joined: Tue Nov 27, 2018 10:30 pm

Re: PR making drilling paths G98 / G99 compatible with NIST std.

Post by freman »

Thanks Gene.

I never got into this before because I thought it was a lot more complicated than it finally was. wsk8's contribution in providing the UI tweeks was a great help. I also didn't realise that all that was needed was to implement what was already codified in NIST standards. Previous discussions gave the impression that coding a solution was just the beginning of an interminable battle over what was needed and how it should be done.

Once I realised all we needed to implement G99 as defined, it became relatively simple.

There has been a resounding silence to my various posts on this problem but hopefully this fix will be integrated.

If not, at least I just have the pain of maintaining a few patches instead of busting my tools and digging holes in my work. I regret not having fixed this earlier.

Thanks for your comments and help on finding a solution.
geant
Posts: 42
Joined: Mon Mar 30, 2015 11:54 pm

Re: PR making drilling paths G98 / G99 compatible with NIST std.

Post by geant »

A very-very long time overdue; Hope this works out! I feel your pain of broken tooling and spoiled/goughed work-pieces.
User avatar
freman
Veteran
Posts: 2201
Joined: Tue Nov 27, 2018 10:30 pm

Re: PR making drilling paths G98 / G99 compatible with NIST std.

Post by freman »

Thanks geant.

This got merged yesterday. I'm glad to see this finally fixed.
Post Reply