[FIXED] TechDraw Detail View circle cropping does not work

Discussions about the development of the TechDraw workbench
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Post Reply
aapo
Posts: 615
Joined: Mon Oct 29, 2018 6:41 pm

[FIXED] TechDraw Detail View circle cropping does not work

Post by aapo »

Hi!

I noticed that the TechDraw Detail View circle cropping does not work any more with the newest TD version, so I think there is a regression with this functionality. The Detail View is supposed to draw a circle around the Detail View and crop everything outside the perimeter of this circle, however in the current version this doesn't seem to work correctly and it's even possible to add a Dimension to the geometry that is supposed to be cropped away (see the attached picture). This is a minor cosmetic inconvenience and it probably should not be high priority, but I wanted to bring this into attention anyway, so that the bug won't be forgotten. Thanks!

EDIT: Could this be caused by the (quite) recent change in the stack ordering of TD objects that fixed another problem with object visibility on pages?

20230310 TD-DetailCircleCroppingBug-pic01.png
20230310 TD-DetailCircleCroppingBug-pic01.png (131.83 KiB) Viewed 751 times

Code: Select all

OS: Windows 10 Version 2009
Word size of FreeCAD: 64-bit
Version: 0.21.0.32198 (Git)
Build type: Release
Branch: master
Hash: f51b2156f35399cab38eef1e957a59ad5a11de66
Python 3.8.16, Qt 5.15.6, Coin 4.0.0, Vtk 9.1.0, OCC 7.6.3
Locale: English/United Kingdom (en_GB)
Installed mods: 
  * Assembly4 0.12.4
  * Curves 0.5.8
  * Defeaturing 1.2.0
  * fasteners 0.4.6
  * FCGear 1.0.0
  * freecad.gears 1.0.0
  * Manipulator 1.4.9
  * Reinforcement
  * Render 2022.2.0
  * sheetmetal 0.2.57
  * ThreadProfile 1.83.0
  * toSketch 1.0.0
Attachments
20230310 TD-DetailCircleCroppingBug.FCStd
(43.83 KiB) Downloaded 28 times
Last edited by aapo on Fri Mar 17, 2023 5:44 pm, edited 1 time in total.
User avatar
wandererfan
Veteran
Posts: 6268
Joined: Tue Nov 06, 2012 5:42 pm
Contact:

Re: [BUG?] TechDraw Detail View circle cropping does not work

Post by wandererfan »

aapo wrote: Fri Mar 10, 2023 1:15 pm I noticed that the TechDraw Detail View circle cropping does not work any more with the newest TD version, so I think there is a regression with this functionality. The Detail View is supposed to draw a circle around the Detail View and crop everything outside the perimeter of this circle, however in the current version this doesn't seem to work correctly and it's even possible to add a Dimension to the geometry that is supposed to be cropped away (see the attached picture). This is a minor cosmetic inconvenience and it probably should not be high priority, but I wanted to bring this into attention anyway, so that the bug won't be forgotten. Thanks!
I haven't looked into this yet, but is this due to line widths? Can you try your file with a really thin line?
aapo
Posts: 615
Joined: Mon Oct 29, 2018 6:41 pm

Re: [BUG?] TechDraw Detail View circle cropping does not work

Post by aapo »

wandererfan wrote: Fri Mar 10, 2023 4:50 pm I haven't looked into this yet, but is this due to line widths? Can you try your file with a really thin line?
That's what I first thought, but as you can see from the screenshot the arcs don't have the same radius, i.e. the Detail View circle is radius 5.00 mm and the offending geometry is radius 5.05 mm, which means it's basically always visible no matter how thin.
User avatar
wandererfan
Veteran
Posts: 6268
Joined: Tue Nov 06, 2012 5:42 pm
Contact:

Re: [BUG?] TechDraw Detail View circle cropping does not work

Post by wandererfan »

aapo wrote: Sat Mar 11, 2023 8:52 am
Should be better after git commit e3dcb24ebe
aapo
Posts: 615
Joined: Mon Oct 29, 2018 6:41 pm

Re: [BUG?] TechDraw Detail View circle cropping does not work

Post by aapo »

wandererfan wrote: Thu Mar 16, 2023 2:45 pm Should be better after git commit e3dcb24ebe
Thanks! Confirmed fixed on Linux! :D I think it should work on Windows, too, although I couldn't test on Windows, because the weekly snapshots have not been updated for a while, and I can't compile on Windows.

20230317 TD-DetailCircleCroppingBug-pic02.png
20230317 TD-DetailCircleCroppingBug-pic02.png (82.47 KiB) Viewed 482 times

Code: Select all

OS: Debian GNU/Linux 12 (bookworm) (KDE/plasma)
Word size of FreeCAD: 64-bit
Version: 0.21.0.32347 (Git)
Build type: Release
Branch: master
Hash: c38fcf8ed723cb9665251c26d2badc6772738e7c
Python 3.11.2, Qt 5.15.8, Coin 4.0.0, Vtk 7.1.1, OCC 7.6.3
Locale: English/United States (en_US)
Installed mods: 
  * Assembly4
  * Render
  * fasteners
  * FCGear
  * Manipulator
  * Curves
  * sheetmetal
Post Reply