Page 2 of 2
Re: Expression Completer - Changes, Fixes
Posted: Tue Jan 24, 2023 12:39 am
by bleber
acpopescu wrote: ↑Sun Jan 22, 2023 1:21 pm
what did you have in mind
A mockup with the process to "catch" a length propriety of an edge.
For maximum flexibility, the reference can ve anything that you can extract a number to assign to an expression to make a formula.
The "another level feature" are make an: if, or, ..... basic programming formulas in the formula editor.
Re: Expression Completer - Changes, Fixes
Posted: Tue Jan 24, 2023 4:42 am
by chennes
Thanks for the PR, and especially for the extended documentation you added to the top of the code -- that makes it much easier to understand what's going on. This is a nice short one, we should be able to get it merged pretty quickly here.
Re: Expression Completer - Changes, Fixes
Posted: Tue Jan 24, 2023 9:02 pm
by chennes
OK, this PR has been merged as of a few minutes ago -- thanks again, @acpopescu.
Re: Expression Completer - Changes, Fixes
Posted: Tue Jan 24, 2023 11:56 pm
by chrisb
I haven't tested yet, but I guess it works.
This is a good example that it it is sensible to have smaller PRs, even if they don't have in one go the full functionality of the final target. @realthunder, care to take a look? Perhaps the rest of PR3062 (I understand there is a rest?) can be split as well in order to be meged more easily.