[Issue #8044] Undo doesn't work on Draft Move function

[Kunda1]

Issue is reported for Version: 0.21.31109 (Git)
Issue isn't reproduced on Version: 0.21.0.31312 (Git)

@acp693 can you test on the latest dev version ?

[acp693]

Just downloaded and tested. Exactly the same behaviour on the latest dev version

Code: Select all

OS: Windows 10 Version 2009
Word size of FreeCAD: 64-bit
Version: 0.21.0.31340 (Git)
Build type: Release
Branch: master
Hash: 856af2a12287a2d7c0d5ab23646be43af26b14b1
Python 3.10.8, Qt 5.15.4, Coin 4.0.0, Vtk 9.1.0, OCC 7.6.3
Locale: German/Germany (de_DE)
Installed mods: 
  * CurvedShapes 1.0.4
  * Curves 0.5.3
  * ExtremeProLight 1.4.3
  * FeedsAndSpeeds 0.5.0
  * Marz 0.0.26-alpha
  * Silk 1.0.0

[Kunda1]

Thanks.

Moved thread to Draft subforum.

[Roy_043]

I have spent some time trying to analyze this bug. It also occurs if you change the Placement of a Draft object in the Properties editor. The problem does not occur in V0.18. It seems some regression, that only affects Windows users apparently, was introduced in V0.19.

Code: Select all

OS: Windows 8.1 Version 6.3 (Build 9600)
Word size of FreeCAD: 64-bit
Version: 0.21.0.31432 (Git)
Build type: Release
Branch: master
Hash: 63a2855751d638bf27ed969dc60654bda2b54baf
Python 3.10.8, Qt 5.15.4, Coin 4.0.0, Vtk 9.1.0, OCC 7.6.3
Locale: Dutch/Netherlands (nl_NL)
Installed mods:

Code: Select all

OS: Windows 8.1
Word size of OS: 64-bit
Word size of FreeCAD: 32-bit
Version: 0.18.4 (GitTag)
Build type: Release
Branch: releases/FreeCAD-0-18
Hash: 980bf9060e28555fecd9e3462f68ca74007b70f8
Python version: 2.7.14
Qt version: 4.8.7
Coin version: 4.0.0a
OCC version: 7.2.0
Locale: Dutch/Netherlands (nl_NL)

[Palmtree]

I have spent some time trying to analyze this bug. It also occurs if you change the Placement of a Draft object in the Properties editor. The problem does not occur in V0.18. It seems some regression, that only affects Windows users apparently, was introduced in V0.19

@Roy_043 you have solved many of my reported bugs/questions.
Many thanks for your confirmation and valuable input to the forum.
Hopefully @acp693's bug report will be solved and merged ASAP
Cheers

[Roy_043]

I have added test files on GitHub:
https://github.com/FreeCAD/FreeCAD/issu ... 1374427577

[acp693]

Tried the new files, works as it should as far as I can tell. Thank you very much @Roy_043

[Roy_043]

Thanks for testing. Still doing some testing myself.

[Palmtree]

Thanks for testing. Still doing some testing myself.

Many thanks for your contribution.
I have been testing for some time, sorry for the slow response.

It does not works all times (rotate or move).
Use the attached test file to reproduce the fault (you may need to repeat both rotate/move to different positions).
Some time works for one fails for other.The attached images works for rotate and fails for move
***********************************************************************
***********************************************************************

Code: Select all

OS: Windows 10 Version 2009
Word size of FreeCAD: 64-bit
Version: 0.21.0.31513 (Git)
Build type: Release
Branch: master
Hash: b2ab8edba4bfd71681e639f8c3f1105066bed4c7
Python 3.10.8, Qt 5.15.4, Coin 4.0.0, Vtk 9.1.0, OCC 7.6.3
Locale: English/Australia (en_AU)
Installed mods: 
  * Behave-Dark-Colors 0.1.1
  * BIM 2021.12.0
  * Defeaturing 1.2.0
  * Dracula 0.0.2
  * ExtremeProDark 2.6.4
  * fasteners 0.4.24
  * ProDarkThemePreferencePack 1.0.0
  * SketchArch

[Roy_043]

Thanks for testing. AFAICT the attached file (gui_base_original.py) fixes this problem.

Target folder for the file:
<installation_folder>/Mod/Draft/draftguitools/