[ ArchSketch - Feature (Merged) Preview ] - Slab, Curtain Wall, ArchWall etc. on Same ArchSketch

A forum dedicated to the Draft, Arch and BIM workbenches development.
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
User avatar
markko martin
Posts: 64
Joined: Tue Aug 09, 2016 5:51 pm
Location: Italy

Re: [ ArchSketch - Feature Preview ] - Slab, Curtain Wall, ArchWall etc. on Same ArchSketch

Post by markko martin »

paullee wrote: Wed Jan 11, 2023 5:24 pm Hmmm, can't see what's wrong, everything seems working here :roll:
Don't worry because it's not a serious bug .
Assuming it's really a bug and not a problem of my pc .

Will you add an edit wall structure command in the future?
I can't wait to use it :D
Loris
paullee
Veteran
Posts: 5120
Joined: Wed May 04, 2016 3:58 pm

Re: [ ArchSketch - Feature Preview ] - Slab, Curtain Wall, ArchWall etc. on Same ArchSketch

Post by paullee »

OK, thanks for testing. You mean add the current command being tested ? or another one with other functionality ?
User avatar
markko martin
Posts: 64
Joined: Tue Aug 09, 2016 5:51 pm
Location: Italy

Re: [ ArchSketch - Feature Preview ] - Slab, Curtain Wall, ArchWall etc. on Same ArchSketch

Post by markko martin »

paullee wrote: Thu Jan 12, 2023 6:20 pm OK, thanks for testing. You mean add the current command being tested ? or another one with other functionality ?
I mean the same command being tested.
Being able to have walls and structures ( slbas , pillars and substructures ) from the same sketch represents 90 % of the work done.

Then in the future it would be nice to have a single command that allows you to change the structure of the floor slabs , walls, curtain wall , stairs, roof, terrain / site but I think it is very complicated to implement.
Loris
paullee
Veteran
Posts: 5120
Joined: Wed May 04, 2016 3:58 pm

Re: [ ArchSketch - Feature Preview ] - Slab, Curtain Wall, ArchWall etc. on Same ArchSketch

Post by paullee »

I see thanks. Only have very little time, and with limited coding knowledge, development is slow indeed :)

Would update the current tested code to github in any rate - hope there maybe some peoples have better idea and much better coding capability may develop more features for Arch/BIM :D

A few thing to note for the time being though:-
  1. ArchStructure is re-factored so user can selected particular edges for building the Structure object
  2. ArchWall is not updated yet at the moment; so every Edges in ArchSketch will be built by ArchWall into walls
  3. Before then, fortunately, user can prevent the Edges (particularly Slab edges) to turn into walls, by simply turning those Edges into Construction Mode
  1. Then, there is kind of 'topo-naming' issue with Sketch also, the code to circumvent in SketchArch WB it is not exposed yet
  2. So at the moment, selected the Edges to build ArchStructure at later stage of the workflow
  3. Otherwise if user edit the ArchSketch, particularly deleting a few edges, the order of index would be frustrated and the shape of Structure possibly; user need to re-do selection of the edges again then
See model file, and screencaptures below.

Test_ ArchSketch_ 101d_ Wall & Slab_0.21_pre.FCStd
(99.49 KiB) Downloaded 33 times

Screenshot from 2023-01-13 19-06-44.png
Screenshot from 2023-01-13 19-06-44.png (236.94 KiB) Viewed 1588 times
Screenshot from 2023-01-13 19-06-50.png
Screenshot from 2023-01-13 19-06-50.png (236.22 KiB) Viewed 1588 times
Screenshot from 2023-01-13 19-07-10.png
Screenshot from 2023-01-13 19-07-10.png (248.11 KiB) Viewed 1588 times
Screenshot from 2023-01-13 19-08-43.png
Screenshot from 2023-01-13 19-08-43.png (258.49 KiB) Viewed 1588 times
Screenshot from 2023-01-13 19-08-52.png
Screenshot from 2023-01-13 19-08-52.png (240.25 KiB) Viewed 1588 times
Screenshot from 2023-01-13 19-09-35.png
Screenshot from 2023-01-13 19-09-35.png (242.2 KiB) Viewed 1588 times
Screenshot from 2023-01-13 19-09-46.png
Screenshot from 2023-01-13 19-09-46.png (244.53 KiB) Viewed 1588 times
paullee
Veteran
Posts: 5120
Joined: Wed May 04, 2016 3:58 pm

Re: [ ArchSketch - Feature Preview ] - Slab, Curtain Wall, ArchWall etc. on Same ArchSketch

Post by paullee »

Ok, SketchArch add-on files further updated, and uploaded to github - https://github.com/paullee0/FreeCAD_SketchArch

SketchArch Add-on Files Updated at github -
  1. ArchSketchObject.py
    ArchSketchObject.py
    (106.97 KiB) Downloaded 31 times
  2. InitGui.py
  3. Edit_Structure_Toggle.svg
Arch WB File - ArchStructure.py
  1. PR to be submitted
  2. (file not repeated here, latest one in the thread to be submitted in a PR)
Anyone would like to try the latest update at github? Thanks in Advance :)
paullee
Veteran
Posts: 5120
Joined: Wed May 04, 2016 3:58 pm

Re: [ ArchSketch - Feature Preview ] - Slab, Curtain Wall, ArchWall etc. on Same ArchSketch

Post by paullee »

PR to update ArchStructure also submitted :D

https://github.com/FreeCAD/FreeCAD/pull/8187
User avatar
markko martin
Posts: 64
Joined: Tue Aug 09, 2016 5:51 pm
Location: Italy

Re: [ ArchSketch - Feature Preview ] - Slab, Curtain Wall, ArchWall etc. on Same ArchSketch

Post by markko martin »

Thank's for your amazing work paulee :D :D :D :D :D :D
paullee wrote: Fri Jan 13, 2023 11:28 am user can prevent the Edges (particularly Slab edges) to turn into walls, by simply turning those Edges into Construction Mode
I was already happy with this tip :)
But now can't wait for the new PR to be added to the master !
paullee wrote: Fri Jan 13, 2023 4:54 pm Ok, SketchArch add-on files further updated, and uploaded to github

I don't understand if it's enough to wait for the new release and update the archsketch workbench from addon manager or if I also have to replace the "ArchSketchObject.py" file.
Loris
paullee
Veteran
Posts: 5120
Joined: Wed May 04, 2016 3:58 pm

Re: [ ArchSketch - Feature Preview ] - Slab, Curtain Wall, ArchWall etc. on Same ArchSketch

Post by paullee »

Just update in Add-on manager should now have your system updated with all files related to SketchArch add-on (including ArchSketchObject.py etc.) . However for FreeCAD itself, need to wait for the ArchStructure.py PR be reviewed and hopfully be merged, and if you use pre-compiled weekly FC version, the next pre-complied FC be released.

However, you can always download the latest ArchStructure.py from the Github PR and update FC with it as you do for testing.

Again, thanks for the testing, improvement ideas etc. :)
paullee
Veteran
Posts: 5120
Joined: Wed May 04, 2016 3:58 pm

Re: [ ArchSketch - Feature Merged ] - Slab, Curtain Wall, ArchWall etc. on Same ArchSketch

Post by paullee »

paullee wrote: Sat Jan 14, 2023 9:48 am PR to update ArchStructure also submitted :D

https://github.com/FreeCAD/FreeCAD/pull/8187
Merged ! Thanks Yorik !

Wait for the next weekly pre-compiled FC, or compile yourself :)
paullee
Veteran
Posts: 5120
Joined: Wed May 04, 2016 3:58 pm

Re: [ ArchSketch - Feature Merged ] - Slab, Curtain Wall, ArchWall etc. on Same ArchSketch

Post by paullee »

paullee wrote: Tue Jan 17, 2023 5:10 pm Wait for the next weekly pre-compiled FC, or compile yourself :)
Weekly builds with above merged PR released :D
- FreeCAD_weekly-builds-31625-2023-01-19-conda-Linux-x86_64-py310

https://github.com/FreeCAD/FreeCAD-Bund ... kly-builds
Post Reply