PartDesign Thickness - inwards by default
Forum rules
Be nice to others! Read the FreeCAD code of conduct!
Be nice to others! Read the FreeCAD code of conduct!
PartDesign Thickness - inwards by default
Hi,
I'd like to suggest a small change. I think that it would be better to set the "Make thickness inwards" option of PartDesign Thickness to be checked by default. That's because such hollowing operations in CAD software are usually performed inwards and it's easy to make a mistake and apply this operation in the opposite direction.
What do you think about this ? Are there any reasons to keep this option unchecked by default ?
I'd like to suggest a small change. I think that it would be better to set the "Make thickness inwards" option of PartDesign Thickness to be checked by default. That's because such hollowing operations in CAD software are usually performed inwards and it's easy to make a mistake and apply this operation in the opposite direction.
What do you think about this ? Are there any reasons to keep this option unchecked by default ?
Re: PartDesign Thickness - inwards by default
+1
For injection-moulded parts you usually design the mould side (outer surface) of a part and use inward thickness to get the die side.
I would start parts to be 3D-printed from the outside as well.
And for deep-drawn sheet metal parts in contrast you usually design the die side and add outward thickness.
I bet the majority of parts represent moulded or 3d-printed parts, that's why I second this change.
- adrianinsaval
- Veteran
- Posts: 5541
- Joined: Thu Apr 05, 2018 5:15 pm
Re: PartDesign Thickness - inwards by default
To implement this, would it be sufficient to replace this piece of code in src/Mod/PartDesign/Gui/TaskThicknessParameters.ui:
with:
or is it more complicated ?
Code: Select all
<widget class="QCheckBox" name="checkReverse">
<property name="text">
<string>Make thickness inwards</string>
</property>
</widget>
Code: Select all
<widget class="QCheckBox" name="checkReverse">
<property name="enabled">
<bool>true</bool>
</property>
<property name="text">
<string>Make thickness inwards</string>
</property>
</widget>
Re: PartDesign Thickness - inwards by default
+1
I seem to recall that thickness is set to outward because OCC is handling better outward than inward which fails more often.
But yes inward should be default.
I seem to recall that thickness is set to outward because OCC is handling better outward than inward which fails more often.
But yes inward should be default.
Support me on Patreon: https://www.patreon.com/FreeCadDevDiary
FreeCad Dev Diary channel:[/b] https://www.youtube.com/channel/UCGMTmJ ... NiPSSEhBHA
FreeCad Dev Diary channel:[/b] https://www.youtube.com/channel/UCGMTmJ ... NiPSSEhBHA
Re: PartDesign Thickness - inwards by default
@paddle Do you know if that code change above is sufficient to change this default setting ?
Re: PartDesign Thickness - inwards by default
This is not enough IMO.NewJoker wrote: ↑Tue Sep 13, 2022 8:54 am To implement this, would it be sufficient to replace this piece of code in src/Mod/PartDesign/Gui/TaskThicknessParameters.ui:
with:Code: Select all
<widget class="QCheckBox" name="checkReverse"> <property name="text"> <string>Make thickness inwards</string> </property> </widget>
or is it more complicated ?Code: Select all
<widget class="QCheckBox" name="checkReverse"> <property name="enabled"> <bool>true</bool> </property> <property name="text"> <string>Make thickness inwards</string> </property> </widget>
If I'm correct, also set it to true here : https://github.com/FreeCAD/FreeCAD/blob ... ss.cpp#L48
EDIT : Most probably even this last change is needed.
Re: PartDesign Thickness - inwards by default
I think that code will only change the UI element default state but it won't set the actual command boolean for that.
So I think you need both the change you mentioned and the change OpenBrain mentioned together.
Support me on Patreon: https://www.patreon.com/FreeCadDevDiary
FreeCad Dev Diary channel:[/b] https://www.youtube.com/channel/UCGMTmJ ... NiPSSEhBHA
FreeCad Dev Diary channel:[/b] https://www.youtube.com/channel/UCGMTmJ ... NiPSSEhBHA
Re: PartDesign Thickness - inwards by default
Can confirm change in the UI is probably useless as default value is overwritten when widget is created with actual object property value : https://github.com/FreeCAD/FreeCAD/blob ... pp#L69-L70