[Tracking] Backport commits to 0.20 branch

Here's the place for discussion related to coding in FreeCAD, C++ or Python. Design, interfaces and structures.
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
marioalexis
Posts: 124
Joined: Wed Jun 19, 2019 7:44 pm

Re: [Tracking] Backport commits to 0.20 branch

Post by marioalexis »

There is a regression reported on the assembly forum (specifically for assembly3) that is resolved by this pull request: https://github.com/FreeCAD/FreeCAD/pull/7236
The fix is embedded with other changes, so it might not be accepted. In that case, I can split the request and solve the specific regression.
Haavard
Posts: 217
Joined: Wed Feb 17, 2021 10:48 pm

Re: [Tracking] Backport commits to 0.20 branch

Post by Haavard »

Could we get these two commits backported for 0.20.2?
They resolve two bugs related to special characters in windows username.

PD: [skip ci] fix UTF-8 handling in Hole feature
TD: fix UTF-8 handling in LineGroup
Haavard
Posts: 217
Joined: Wed Feb 17, 2021 10:48 pm

Re: [Tracking] Backport commits to 0.20 branch

Post by Haavard »

And also this, Werner mass fixed this UTF-8 bug in all/most of the codebase.
https://github.com/FreeCAD/FreeCAD/comm ... 75694eb505

Hopefully FreeCAD should be compatible with all windows usernames now 8-)
Syres
Veteran
Posts: 2893
Joined: Thu Aug 09, 2018 11:14 am

Re: [Tracking] Backport commits to 0.20 branch

Post by Syres »

Could this bugfix please be backported git commit 9ff0ae5 it's to help prevent drill bit crashes.
User avatar
wandererfan
Veteran
Posts: 6268
Joined: Tue Nov 06, 2012 5:42 pm
Contact:

Re: [Tracking] Backport commits to 0.20 branch

Post by wandererfan »

If v0.20 is required to support Python >3.09, then this git commit 3b29cf18be ([Part]fix makeWireString for Win & Py > 3.09) should be backported.
User avatar
wandererfan
Veteran
Posts: 6268
Joined: Tue Nov 06, 2012 5:42 pm
Contact:

Re: [Tracking] Backport commits to 0.20 branch

Post by wandererfan »

Wrong spelling of leader line preference: http://github.com/FreeCAD/FreeCAD/commit/e28317f772
User avatar
uwestoehr
Veteran
Posts: 4961
Joined: Sun Jan 27, 2019 3:21 am
Location: Germany
Contact:

Re: [Tracking] Backport commits to 0.20 branch

Post by uwestoehr »

marioalexis wrote: Thu Aug 18, 2022 1:34 pm The fix is embedded with other changes, so it might not be accepted. In that case, I can split the request and solve the specific regression.
Thanks. Yes, can you please make a separate PR directly for the 0-20 branch?
User avatar
uwestoehr
Veteran
Posts: 4961
Joined: Sun Jan 27, 2019 3:21 am
Location: Germany
Contact:

Re: [Tracking] Backport commits to 0.20 branch

Post by uwestoehr »

User avatar
uwestoehr
Veteran
Posts: 4961
Joined: Sun Jan 27, 2019 3:21 am
Location: Germany
Contact:

Re: [Tracking] Backport commits to 0.20 branch

Post by uwestoehr »

Syres wrote: Sun Sep 04, 2022 12:25 pm Could this bugfix please be backported git commit 9ff0ae5 it's to help prevent drill bit crashes.
Thanks. Backported now for 0.20.2
User avatar
uwestoehr
Veteran
Posts: 4961
Joined: Sun Jan 27, 2019 3:21 am
Location: Germany
Contact:

Re: [Tracking] Backport commits to 0.20 branch

Post by uwestoehr »

wandererfan wrote: Thu Sep 08, 2022 1:32 pm If v0.20 is required to support Python >3.09, then this git commit 3b29cf18be ([Part]fix makeWireString for Win & Py > 3.09) should be backported.
0.20 will not raise the required Python version but I think it is very valuable to support in the stable branch newer Python versions -> backported now.
Post Reply