#4828 PartDesign: inverse for pocket

Post here if you have re-based and finalised code to integrate into master, which was discussed, agreed to and tested in other forums. You can also submit your PR directly on github.
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Post Reply
rynn
Posts: 454
Joined: Tue Jul 31, 2018 7:00 am

#4828 PartDesign: inverse for pocket

Post by rynn »

This adds an “inverse” option for PartDesign pocket feature.
Essentially this cuts away anything that is +not+ covered by the
sketch. (boolean common instead of cut.)

see englisch or german forum.

https://github.com/FreeCAD/FreeCAD/pull/4828
GeneFC
Veteran
Posts: 5373
Joined: Sat Mar 19, 2016 3:36 pm
Location: Punta Gorda, FL

Re: #4828 PartDesign: inverse for pocket

Post by GeneFC »

I would use this a lot. Thanks!

However, the name seems a bit confusing, at least in English. To me an "inverse pocket" would be the same as a "pad".

I have not thought enough about a better name, but something like "outer pocket" or "external pocket" would sound better to me.

Gene
chrisb
Veteran
Posts: 53930
Joined: Tue Mar 17, 2015 9:14 am

Re: #4828 PartDesign: inverse for pocket

Post by chrisb »

Isn't this a boolean "Common"?
A Sketcher Lecture with in-depth information is available in English, auf Deutsch, en français, en español.
rynn
Posts: 454
Joined: Tue Jul 31, 2018 7:00 am

Re: #4828 PartDesign: inverse for pocket

Post by rynn »

chrisb wrote: Mon Aug 16, 2021 9:47 pm Isn't this a boolean "Common"?
Yes.
GeneFC wrote: Mon Aug 16, 2021 9:25 pm However, the name seems a bit confusing, at least in English.
In the UI it’s called “remove outside of profile” now.¹
The parameter is called “Outside”.
__________
¹ The new naming came with Adrians patch
openBrain
Veteran
Posts: 9034
Joined: Fri Nov 09, 2018 5:38 pm
Contact:

Re: #4828 PartDesign: inverse for pocket

Post by openBrain »

rynn wrote: Mon Aug 16, 2021 5:53 pm This adds an “inverse” option for PartDesign pocket feature.
Essentially this cuts away anything that is +not+ covered by the
sketch. (boolean common instead of cut.)
The PR is pretty old. Is there a particular reason why you opened this thread ?
chrisb wrote: Mon Aug 16, 2021 9:47 pm Isn't this a boolean "Common"?
No please. I'm in favor that boolean vocabulary is kept away from PartDesign. :)
rynn
Posts: 454
Joined: Tue Jul 31, 2018 7:00 am

Re: #4828 PartDesign: inverse for pocket

Post by rynn »

openBrain wrote: Tue Aug 17, 2021 7:00 am The PR is pretty old. Is there a particular reason why you opened this thread ?
Yes. Because it is pretty old ;)
openBrain
Veteran
Posts: 9034
Joined: Fri Nov 09, 2018 5:38 pm
Contact:

Re: #4828 PartDesign: inverse for pocket

Post by openBrain »

rynn wrote: Tue Aug 17, 2021 9:17 am Yes. Because it is pretty old ;)
Actually it's not regarding FC merging pace. I have one that is 1.5-year old while only a few lines. :) Being patient is the only way to go. :lol:
chrisb
Veteran
Posts: 53930
Joined: Tue Mar 17, 2015 9:14 am

Re: #4828 PartDesign: inverse for pocket

Post by chrisb »

openBrain wrote: Tue Aug 17, 2021 7:00 am No please. I'm in favor that boolean vocabulary is kept away from PartDesign. :)
Agreed, as we don't call a Pad a Union :) .
A Sketcher Lecture with in-depth information is available in English, auf Deutsch, en français, en español.
ThomasT
Posts: 4
Joined: Tue Aug 17, 2021 9:36 pm

Re: #4828 PartDesign: inverse for pocket

Post by ThomasT »

Would "Crop" be a good name for this function? It is short and is known from 2D programs.
rynn
Posts: 454
Joined: Tue Jul 31, 2018 7:00 am

Re: #4828 PartDesign: inverse for pocket

Post by rynn »

And… another month gone – frustrating.
Post Reply