GSoC Proposal: Extended functionality of Rebar Addon

[Suraj Dadral]

for exporting to DXF, I think we must split some function for writing SVG (get*SVGData) to get the edges of rebars, I wrote a macro to examine this for uUShapeRebar:

Hi @ebrahim raeyat

As getUShapeRebarSVGData (get*SVGData) function returns dictionary of data, so we can just add one more value (edges_list) to dictionary to return.
So, function return statement will be like:

Code: Select all

return {
    "svg": stirrup_svg,
    "visibility": is_rebar_visible,
    "edges": visible_edges_list,
}

Benefit of using this approach instead of refactoring functions is we need to make less changes to functions. Other functions using these functions will work without any changes.

Thanks,

[Suraj Dadral]

Hi @All

The Reinforcement Drawing Dimensioning GUI made by @balrobs is integrated into Rinforcement Workbench as per PR: https://github.com/amrit3701/FreeCAD-Re ... t/pull/119
Will be merged into master branch soon...

Till then, you may test it by getting code from "integrate-drawing-dimensioning-ui" branch from here: https://github.com/SurajDadral/FreeCAD- ... sioning-ui

ShapeUi.png (53.01 KiB) Viewed 3641 times

DrawingUi.png (73.7 KiB) Viewed 3641 times

DimensionUI1.png (61.97 KiB) Viewed 3641 times

DimensionUI2.png (61.39 KiB) Viewed 3641 times

DimensionUI3.png (66.76 KiB) Viewed 3641 times

Thanks,

[ebrahim raeyat]

for exporting to DXF, I think we must split some function for writing SVG (get*SVGData) to get the edges of rebars, I wrote a macro to examine this for uUShapeRebar:

Hi @ebrahim raeyat

As getUShapeRebarSVGData (get*SVGData) function returns dictionary of data, so we can just add one more value (edges_list) to dictionary to return.
So, function return statement will be like:

Code: Select all

return {
    "svg": stirrup_svg,
    "visibility": is_rebar_visible,
    "edges": visible_edges_list,
}

Benefit of using this approach instead of refactoring functions is we need to make less changes to functions. Other functions using these functions will work without any changes.

Thanks,

Thanks @Suraj Dadral. You right. it is a true solution. but I think we can add some helper function like get_ushape_rebar_edges and so on and call these in getUShapeRebarSVGData (get*SVG). this way, the code didn't need to change, is it possible? I say this only for speed performance in large files and the zen of python. each function must do one and exactly one thing.

thanks.

[Suraj Dadral]

Thanks @Suraj Dadral. You right. it is a true solution. but I think we can add some helper function like get_ushape_rebar_edges and so on and call these in getUShapeRebarSVGData (get*SVG). this way, the code didn't need to change, is it possible? I say this only for speed performance in large files and the zen of python. each function must do one and exactly one thing.

thanks.

In above, I am assuming that get_ushape_rebar_edges() will return only visible edges (Right?).
In function getUShapeRebarSVGData(), to check if an edge is visible or not, I first generated SVG of each edge and then checked for each edge having unique svg is visible.

So, if we need get_ushape_rebar_edges() should only return visible edges and if we are not going to change above logic of finding visible edges, then its better to return visible edges from getUShapeRebarSVGData() function.
Otherwise we will be first generating svg of each edge in get_ushape_rebar_edges() function to find visible edges and then again generating svg of each edge in getUShapeRebarSVGData(), which will degrade performance.

If get_ushape_rebar_edges() should return all edges of rebar, then we can surely refactor getUShapeRebarSVGData() function.

Thanks,

[atomkarinca]

I guess crossties aren't supported yet. Is this something that's in the roadmap?

Hi @atomkarinca

Yes crossties aren't present as special rebar types in Reinforcement Workbench. But, these can be easily created using Arch_Rebar tool.
But, having crossties as special rebar type may make things more easy, so created an issue regarding same here to implement later.

Thanks,

Thanks @Suraj Dadral, that's amazing.

Another amazing feature would be chair rebars:

[ebrahim raeyat]

Thanks @Suraj Dadral. You right. it is a true solution. but I think we can add some helper function like get_ushape_rebar_edges and so on and call these in getUShapeRebarSVGData (get*SVG). this way, the code didn't need to change, is it possible? I say this only for speed performance in large files and the zen of python. each function must do one and exactly one thing.

thanks.

In above, I am assuming that get_ushape_rebar_edges() will return only visible edges (Right?).
In function getUShapeRebarSVGData(), to check if an edge is visible or not, I first generated SVG of each edge and then checked for each edge having unique svg is visible.

So, if we need get_ushape_rebar_edges() should only return visible edges and if we are not going to change above logic of finding visible edges, then its better to return visible edges from getUShapeRebarSVGData() function.
Otherwise we will be first generating svg of each edge in get_ushape_rebar_edges() function to find visible edges and then again generating svg of each edge in getUShapeRebarSVGData(), which will degrade performance.

If get_ushape_rebar_edges() should return all edges of rebar, then we can surely refactor getUShapeRebarSVGData() function.

Thanks,

I am not familiar with SVG, but I say we can get the list of edges from a function and then send the list to each function that need this edges to draw, in SVG or DXF or even plot it via matplotlib.

[Suraj Dadral]

I am not familiar with SVG, but I say we can get the list of edges from a function and then send the list to each function that need this edges to draw, in SVG or DXF or even plot it via matplotlib.

Looks Great . I will try to refactor the get*SVGData() functions maybe this weekend.

Thanks,

[ebrahim raeyat]

I am not familiar with SVG, but I say we can get the list of edges from a function and then send the list to each function that need this edges to draw, in SVG or DXF or even plot it via matplotlib.

Looks Great . I will try to refactor the get*SVGData() functions maybe this weekend.

Thanks,

Thanks, I think this way we have robust API

[balrobs]

Hi @All
The Reinforcement Drawing Dimensioning GUI made by @balrobs is integrated into Rinforcement Workbench as per PR: https://github.com/amrit3701/FreeCAD-Re ... t/pull/119
Will be merged into master branch soon...
Till then, you may test it by getting code from "integrate-drawing-dimensioning-ui" branch from here: https://github.com/SurajDadral/FreeCAD- ... sioning-ui

Hi @Suraj Dadral,
amazing work! I tried your latest code on my windows machine and it works like a charme
Thanks a lot for giving a sense to my work.
BTW do you know a possible workflow to put different views (e.g. Front and Top) of the same structural element on the same drawing sheet? I tried this

1. create drawing sheet with <Front view>
2. adapt <scale type> and <scale parameter> for all elements of the <Front view>
3. create drawing sheet with <Top view>
4. adapt <scale type> and <scale parameter> for all elements of the <Top view>
5. here I stuck ... I'd like to merge both views in a single drawing sheet but I don't know how?

Your advice is highly appreciated!

[Kunda1]

The Reinforcement Drawing Dimensioning GUI made by @balrobs is integrated into Rinforcement Workbench as per PR: https://github.com/amrit3701/FreeCAD-Re ... t/pull/119
Will be merged into master branch soon...

amazing work! I tried your latest code on my windows machine and it works like a charme
Thanks a lot for giving a sense to my work.

Can we see some screencasts of this in action ?