Builds fail on windows

[paddle]

I tried to rebase 2 hours ago and I can't get it to build. On windows / visual studio.

Severity Code Description Project File Line Suppression State
Error C2065 'BRepFeat_MakeRevol': undeclared identifier PartDesign C:\Users\Sky_l\Desktop\Freecad-Src\src\Mod\PartDesign\App\FeatureRevolution.cpp 327
Error C2146 syntax error: missing ';' before identifier 'RevolMaker' PartDesign C:\Users\Sky_l\Desktop\Freecad-Src\src\Mod\PartDesign\App\FeatureRevolution.cpp 327
Error C2065 'RevolMaker': undeclared identifier PartDesign C:\Users\Sky_l\Desktop\Freecad-Src\src\Mod\PartDesign\App\FeatureRevolution.cpp 327
Error C2065 'RevolMaker': undeclared identifier PartDesign C:\Users\Sky_l\Desktop\Freecad-Src\src\Mod\PartDesign\App\FeatureRevolution.cpp 330

Apparantly the root problem comes from BRepFeat_MakeRevol not being defined.
@chris Any idea what could introduce this in what you guys merged today?

[paddle]

Code: Select all

#include "PreCompiled.h"
#ifndef _PreComp_
# include <BRepPrimAPI_MakeRevol.hxx>
# include <BRepFeat_MakeRevol.hxx>
#endif

I checked and BRepFeat_MakeRevol is not in OpenCascadeAll.h (ie in precompiled.h

[chennes]

Possibly you meant to ping me (@chennes) here... but no, I don't know what got merged today that broke this header chain. See PR here: https://github.com/FreeCAD/FreeCAD/pull/11470

[chennes]

Oh, it was https://github.com/FreeCAD/FreeCAD/pull/7193/files -- I was mislead by the dates in the blame.

[paddle]

Ah yes I mentioned the wrong person !
Great thanks