build failure with vtk 9.3

[adrianinsaval]

after recent update on archlinux this error appears:

Code: Select all

[41/5495] Building CXX object src/3rdParty/salomesmesh/CMakeFiles/SMDS.dir/src/SMDS/SMDS_UnstructuredGrid.cpp.o
FAILED: src/3rdParty/salomesmesh/CMakeFiles/SMDS.dir/src/SMDS/SMDS_UnstructuredGrid.cpp.o 
/usr/sbin/ccache /usr/lib/ccache/bin/c++ -DCSFDB -DDIY_NO_THREADS -DH5_BUILT_AS_DYNAMIC_LIB -DHAVE_CONFIG_H -DHAVE_LIMITS_H -DLIN -DMPICH_SKIP_MPICXX -DMPI_NO_CPPBIND -DOCC_CONVERT_SIGNALS -DOMPI_SKIP_MPICXX -DPYCXX_6_2_COMPATIBILITY -DQT_NO_KEYWORDS -DSMDS_EXPORTS -D_MPICC_H -D_OCC64 -Dkiss_fft_scalar=double -I/__w/pacman-repo/pacman-repo/PKGBUILD/freecad-git/src/FreeCAD/build/src/3rdParty/salomesmesh/SMDS_autogen/include -I/__w/pacman-repo/pacman-repo/PKGBUILD/freecad-git/src/FreeCAD/build -I/__w/pacman-repo/pacman-repo/PKGBUILD/freecad-git/src/FreeCAD/build/src -I/__w/pacman-repo/pacman-repo/PKGBUILD/freecad-git/src/FreeCAD/src -I/__w/pacman-repo/pacman-repo/PKGBUILD/freecad-git/src/FreeCAD/src/3rdParty/salomesmesh/src/SMDS -I/__w/pacman-repo/pacman-repo/PKGBUILD/freecad-git/src/FreeCAD/src/3rdParty/salomesmesh/src/Driver -I/__w/pacman-repo/pacman-repo/PKGBUILD/freecad-git/src/FreeCAD/src/3rdParty/salomesmesh/src/DriverUNV -I/__w/pacman-repo/pacman-repo/PKGBUILD/freecad-git/src/FreeCAD/src/3rdParty/salomesmesh/src/DriverDAT -I/__w/pacman-repo/pacman-repo/PKGBUILD/freecad-git/src/FreeCAD/src/3rdParty/salomesmesh/src/DriverSTL -I/__w/pacman-repo/pacman-repo/PKGBUILD/freecad-git/src/FreeCAD/src/3rdParty/salomesmesh/src/StdMeshers -I/__w/pacman-repo/pacman-repo/PKGBUILD/freecad-git/src/FreeCAD/src/3rdParty/salomesmesh/inc -I/__w/pacman-repo/pacman-repo/PKGBUILD/freecad-git/src/FreeCAD/build/src/3rdParty/salomesmesh -isystem /usr/include/opencascade -isystem /usr/include/vtk -isystem /usr/include/freetype2 -Wall -Wextra -Wno-write-strings -march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions         -Wp,-D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security         -fstack-clash-protection -fcf-protection -Wp,-D_GLIBCXX_ASSERTIONS -fPIC -w -Wno-sign-compare -Wno-reorder -Wno-switch -Wno-unused-variable -Wno-unused-but-set-variable -Wno-comment -Wno-unused-parameter -Wno-empty-body -Wno-pedantic -Wno-unused-result -Wno-cast-function-type -Wno-maybe-uninitialized -Wno-missing-field-initializers -std=gnu++17 -fPIC -fopenmp -MD -MT src/3rdParty/salomesmesh/CMakeFiles/SMDS.dir/src/SMDS/SMDS_UnstructuredGrid.cpp.o -MF src/3rdParty/salomesmesh/CMakeFiles/SMDS.dir/src/SMDS/SMDS_UnstructuredGrid.cpp.o.d -o src/3rdParty/salomesmesh/CMakeFiles/SMDS.dir/src/SMDS/SMDS_UnstructuredGrid.cpp.o -c /__w/pacman-repo/pacman-repo/PKGBUILD/freecad-git/src/FreeCAD/src/3rdParty/salomesmesh/src/SMDS/SMDS_UnstructuredGrid.cpp
/__w/pacman-repo/pacman-repo/PKGBUILD/freecad-git/src/FreeCAD/src/3rdParty/salomesmesh/src/SMDS/SMDS_UnstructuredGrid.cpp: In member function ‘void SMDS_UnstructuredGrid::BuildLinks()’:
/__w/pacman-repo/pacman-repo/PKGBUILD/freecad-git/src/FreeCAD/src/3rdParty/salomesmesh/src/SMDS/SMDS_UnstructuredGrid.cpp:1029:25: error: no matching function for call to ‘vtkCellLinks::BuildLinks(SMDS_UnstructuredGrid*)’
 1029 |   GetLinks()->BuildLinks(this);
      |   ~~~~~~~~~~~~~~~~~~~~~~^~~~~~
In file included from /__w/pacman-repo/pacman-repo/PKGBUILD/freecad-git/src/FreeCAD/src/3rdParty/salomesmesh/inc/SMDS_UnstructuredGrid.hxx:30,
                 from /__w/pacman-repo/pacman-repo/PKGBUILD/freecad-git/src/FreeCAD/src/3rdParty/salomesmesh/src/SMDS/SMDS_UnstructuredGrid.cpp:20:
/usr/include/vtk/vtkCellLinks.h:56:8: note: candidate: ‘virtual void vtkCellLinks::BuildLinks()’
   56 |   void BuildLinks() override;
      |        ^~~~~~~~~~
/usr/include/vtk/vtkCellLinks.h:56:8: note:   candidate expects 0 arguments, 1 provided

[funny0facer]

I can confirm. I just wanted to try to compile FreeCAD for the first time and got a similiar text in stderr.

I downgraded vtk to vtk-9.2.6-11 and were able to compile.

[funny0facer]

I guess, this is a change from upstream. See https://github.com/Kitware/VTK/commit/6 ... 421f06f910

Commit Comment of that:

vtkAbstractCellLinks: Use SetDataSet/BuildLinks instead of BuildLinks…

…(dataset)

vtkAbstractCellLinks now use the SetDataSet/BuildLinks like vtkLocators instead of
BuildLinks(dataset) which has been deprecated. Because of this change now we are
able to store built time and check the dataset time to avoid unnecessary rebuilding
of the links. Also deprecated vtkUnstructuredGrid::GetCellLinks() function.

[chrisb]

@adrianinsaval, would you mind correcting the typo in the title?

[adrianinsaval]

@adrianinsaval, would you mind correcting the typo in the title?

done!


the archlinux guys have a patch for it already:
https://gitlab.archlinux.org/archlinux/ ... k9.3.patch

I'll be making a PR out of it

[hhassey]

after recent update on archlinux this error appears:

Can confirm also. I had been compiling FreeCAD with no issues at least once every couple days for a long time. Being totally ignorant about the issue, I thought that the recent update Arch got on opencascade had something to do. Apparently not.

I hope the PR gets on main quickly, I use FreeCAD professionally. If I use an app image in the meantime, will my macros still be there?

Thanks all.
Humberto

[funny0facer]

If I use an app image in the meantime, will my macros still be there?

I just checked and even the Tweak value of Zoom1:1 macro was there. Feel free to try out the AppImage. The theming was not consistent with my DE, but in the end, it works fine.

[adrianinsaval]

Issue has been solved on master

[obelisk79]

Issue has been solved on master

Great news, now I can update vtk again