Updating old theme's

A forum for research and development of the user interface of FreeCAD
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
User avatar
MisterMaker
Posts: 739
Joined: Mon Sep 21, 2020 7:41 am

Re: Updating old theme's

Post by MisterMaker »

On further exploration on this issue I come to the conclusion the gray out is not dark enough for a dark theme.
I read on QT website:
The default engine scales pixmaps down if required, but never up, and it uses the current style to calculate a disabled appearance.
But if I compare dark theme with no theme/light the gray out icons are the same:
Image
dark vs no stylesheet
User avatar
paddle
Veteran
Posts: 1392
Joined: Mon Feb 03, 2020 4:47 pm

Re: Updating old theme's

Post by paddle »

MisterMaker wrote: Thu May 25, 2023 8:09 pm But there are a lot of icons that have white and maybe a color, like the new icon or almost all sketch icons.
Yes but colorblinds with a single channel off, do not see red color gray. They see it green (kind of).
Last edited by paddle on Thu Jul 20, 2023 2:02 pm, edited 1 time in total.
User avatar
MisterMaker
Posts: 739
Joined: Mon Sep 21, 2020 7:41 am

Re: Updating old theme's

Post by MisterMaker »

Made a github issue about it.
Probably gonna ask on Qt forum on how this should work.
https://github.com/FreeCAD/FreeCAD/issues/9673
User avatar
MisterMaker
Posts: 739
Joined: Mon Sep 21, 2020 7:41 am

Re: Updating old theme's

Post by MisterMaker »

I updated my EPD theme with your feedback: viewtopic.php?t=68973
I also removed some borders from spinbox and that other one.
User avatar
MisterMaker
Posts: 739
Joined: Mon Sep 21, 2020 7:41 am

Re: Updating old theme's

Post by MisterMaker »

This is how it looks now for the darker blue:
Image
User avatar
MisterMaker
Posts: 739
Joined: Mon Sep 21, 2020 7:41 am

Re: Updating old theme's

Post by MisterMaker »

Code attached!
Attachments
Darker-blue_new.zip
(9.49 KiB) Downloaded 38 times
User avatar
MisterMaker
Posts: 739
Joined: Mon Sep 21, 2020 7:41 am

Re: Updating old theme's

Post by MisterMaker »

Managed to make a PR, although it somehow took my gitignore with it....
https://github.com/FreeCAD/FreeCAD/pull/9715
Highlight colors used are as followed:
darker
blue #2053c0 #1b3774
green #74831d #6d8000
orange #b28416 #996b00
pink #b216a0 #770069
dark
blue  #4882ff #3f7cff
green #a1bd00 #819700
orange #c8951c #926600
pink #bc1cc8 #920077
light
blue #8cb0ff #b0c9ff
green #B7D300 #E1FF00
orange #ffb916 #ffe098
pink #f892ff #ffbff3
User avatar
MisterMaker
Posts: 739
Joined: Mon Sep 21, 2020 7:41 am

Re: Updating old theme's

Post by MisterMaker »

I made a github repro with all the new theme's so it can be installed true the addon manager.
I don't think any new updates to the theme's get pushed to any clients like built-in addons are?
https://github.com/MisterMakerNL/Freeca ... emes-beta/
I am also open for the idea to just remove all build-in theme's and just point to the addon manager to get theme's. Since the addon manager does a great job in keeping it all up-to-date.
User avatar
adrianinsaval
Veteran
Posts: 5541
Joined: Thu Apr 05, 2018 5:15 pm

Re: Updating old theme's

Post by adrianinsaval »

I tried adding the repo to the addon manager and installing but it doesn't work
Attachments
Screenshot 2023-06-30 190803.png
Screenshot 2023-06-30 190803.png (12.3 KiB) Viewed 2818 times
app4soft
Posts: 78
Joined: Sat Feb 25, 2023 6:23 pm
Location: Ukraine
Contact:

Re: Updating old theme's

Post by app4soft »

adrianinsaval wrote: Fri Jun 30, 2023 11:09 pm I tried adding the repo to the addon manager and installing but it doesn't work
The issue was related to package.xml, that had no defined default branch (which should be set as main), and Addon Manager decides that default branch is master (which was default on GitHub, for years).
Screenshot_2023-07-09_17-49-35.png
Screenshot_2023-07-09_17-49-35.png (140.88 KiB) Viewed 2488 times
So, Addon Manager tried to reach master branch (ignoring even custom repo branch setting), then GitHub redirected it to main and since then there is some issue with Addon Manager that does not fully detected this redirect, but still could install such addon. That is in part Addon Manager issue.

BTW, I just helped to fix this and @MisterMaker already updated repo: https://github.com/MisterMakerNL/Freeca ... /tree/main

Before install cleanup Addon Manager cache: ~/.cache/FreeCAD/Cache/AddonManager

Then restart FreeCAD, add custom repo into Addon Manager (do not forget set main branch), launch Addon Manager and install theme.
Screenshot_2023-07-09_20-16-39.png
Screenshot_2023-07-09_20-16-39.png (69.44 KiB) Viewed 2473 times
:idea: Commissions Open! https://bmc.link/app4soft/commissions
Making 2D/3D CAD with FreeCAD, LibreCAD & SolveSpace apps.
YouTube: https://youtube.com/@app4soft
BMC: https://buymeacoffee.com/app4soft
Patreon: https://patreon.com/app4soft (all FREE)
Post Reply