Contributing without github account

Merged, abandoned or rejected pull requests are moved here to clear the main Pull Requests forum.
wmayer
Founder
Posts: 20242
Joined: Thu Feb 19, 2009 10:32 am
Contact:

Re: Contributing without github account

Post by wmayer »

User avatar
PrzemoF
Veteran
Posts: 3520
Joined: Fri Jul 25, 2014 4:52 pm
Contact:

Re: Contributing without github account

Post by PrzemoF »

@wmayer
Another one please: https://github.com/PrzemoF/FreeCAD/tree/copr_fix_v61
Do we still have Licence.txt somewhere? I can't locate it.
wmayer
Founder
Posts: 20242
Joined: Thu Feb 19, 2009 10:32 am
Contact:

Re: Contributing without github account

Post by wmayer »

PrzemoF wrote: Tue Apr 18, 2023 6:50 pm Do we still have Licence.txt somewhere? I can't locate it.
We had one in data but that was removed with git commit f22c391700fc78e as requested by a Debian maintainer. See viewtopic.php?p=665513#p665513
Something is wrong with your PR as it contains stuff of other PRs. I guess you only want the top commit.
User avatar
PrzemoF
Veteran
Posts: 3520
Joined: Fri Jul 25, 2014 4:52 pm
Contact:

Re: Contributing without github account

Post by PrzemoF »

Thanks for catching that! I think something weird happened with force push. I did a deep master branch reset, pulled it again and then applied my commit, but looks that was not enough to fix it.
wmayer
Founder
Posts: 20242
Joined: Thu Feb 19, 2009 10:32 am
Contact:

Re: Contributing without github account

Post by wmayer »

Don't worry. I have fixed it in my PR and merged it already.
User avatar
PrzemoF
Veteran
Posts: 3520
Joined: Fri Jul 25, 2014 4:52 pm
Contact:

Re: Contributing without github account

Post by PrzemoF »

Thank you! I see that the builds are back :D Thanks for @mr-miky as well! He did the hard part!
User avatar
PrzemoF
Veteran
Posts: 3520
Joined: Fri Jul 25, 2014 4:52 pm
Contact:

Re: Contributing without github account

Post by PrzemoF »

@wmayer

Please pull https://github.com/PrzemoF/FreeCAD/tree/copr_fix_v66
There is a new plugin that was not listed derailing the build.
wmayer
Founder
Posts: 20242
Joined: Thu Feb 19, 2009 10:32 am
Contact:

Re: Contributing without github account

Post by wmayer »

Merged.
User avatar
PrzemoF
Veteran
Posts: 3520
Joined: Fri Jul 25, 2014 4:52 pm
Contact:

Re: Contributing without github account

Post by PrzemoF »

@wmayer

Please pull this one: https://github.com/PrzemoF/FreeCAD/tree/copr_fix_v67
It only affects the fedora nightly spec file, so it's safe

Thank you!!
Post Reply