PartDesign Shapebinders: the property "Support" and Attachment clash

About the development of the Part Design module/workbench. PLEASE DO NOT POST HELP REQUESTS HERE!
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
user1234
Veteran
Posts: 3332
Joined: Mon Jul 11, 2016 5:08 pm

PartDesign Shapebinders: the property "Support" and Attachment clash

Post by user1234 »

Hello!

The Shapebinders in PartDesign have the property Support, but also Attachments have them. So you can not add any Attachment on it. Because when you add an Attachment on Shapebinders, in the Attachment you have the list of Shapebinder geometries, even when it is on an other group.

Is it possible to rename this property in the Shapebinders?


Greetings
user1234
User avatar
Vincent B
Veteran
Posts: 4713
Joined: Sun Apr 05, 2015 9:02 am
Location: La Rochelle, France

Re: PartDesign Shapebinders: the property "Support" and Attachment clash

Post by Vincent B »

Agree with that. Shapebinder must be attach..able. With it was no planned? :roll:
As with the link version.
Attachments
Capture.JPG
Capture.JPG (30.18 KiB) Viewed 1846 times
User avatar
adrianinsaval
Veteran
Posts: 5541
Joined: Thu Apr 05, 2018 5:15 pm

Re: PartDesign Shapebinders: the property "Support" and Attachment clash

Post by adrianinsaval »

Please create a github issue about this
user1234
Veteran
Posts: 3332
Joined: Mon Jul 11, 2016 5:08 pm

Re: PartDesign Shapebinders: the property "Support" and Attachment clash

Post by user1234 »

joshc wrote: Sat Feb 24, 2024 7:00 am PR: https://github.com/FreeCAD/FreeCAD/pull/12579
Nice. But a few question:

- is it possible to open old file properly after the merge?

- is then also the normal shapebinder necessary? Because then the subshapebinder can do much more as the shapebinder. The only thing what is then missing is a dialog and the property trace support.


Greetings
user1234
joshc
Posts: 19
Joined: Fri Jan 19, 2024 1:11 am

Re: PartDesign Shapebinders: the property "Support" and Attachment clash

Post by joshc »

user1234 wrote: Sat Feb 24, 2024 4:58 pm - is it possible to open old file properly after the merge?
Yep, I added handleChangedPropertyName() impls for that. It worked as expected on a project I created with a release version.
user1234 wrote: Sat Feb 24, 2024 4:58 pm - is then also the normal shapebinder necessary? Because then the subshapebinder can do much more as the shapebinder. The only thing what is then missing is a dialog and the property trace support.
Agreed, but I didn't try to unify them. I did fix the problem for both normal and sub binders though.
user1234
Veteran
Posts: 3332
Joined: Mon Jul 11, 2016 5:08 pm

Re: PartDesign Shapebinders: the property "Support" and Attachment clash

Post by user1234 »

joshc wrote: Sat Feb 24, 2024 5:41 pm Yep, I added handleChangedPropertyName() impls for that.
Thanks.


Greetings
user1234
User avatar
adrianinsaval
Veteran
Posts: 5541
Joined: Thu Apr 05, 2018 5:15 pm

Re: PartDesign Shapebinders: the property "Support" and Attachment clash

Post by adrianinsaval »

Suggestions for how the property should be called are welcome
chrisb
Veteran
Posts: 53920
Joined: Tue Mar 17, 2015 9:14 am

Re: PartDesign Shapebinders: the property "Support" and Attachment clash

Post by chrisb »

adrianinsaval wrote: Wed Feb 28, 2024 2:36 am Suggestions for how the property should be called are welcome
Shape (according to Part booleans)
Base (because it tastes a bit like a BaseFeature)
Profile (according to PartDesign features)
Originals (according to PartDesign patterns)
Source (I'm very sure it is used somewhere)
A Sketcher Lecture with in-depth information is available in English, auf Deutsch, en français, en español.
User avatar
adrianinsaval
Veteran
Posts: 5541
Joined: Thu Apr 05, 2018 5:15 pm

Re: PartDesign Shapebinders: the property "Support" and Attachment clash

Post by adrianinsaval »

chrisb wrote: Wed Feb 28, 2024 8:40 am
Shape is already a property of all Part::Feature derived objects (anything that's brep essentially), although it's normally hidden by default. That one can't be used.

Profile doesn't seem right to me, sometimes you use binders on whole solids or just on edges or even just on points.

Any of the others seem good to me, I had also proposed the name Source on the github PR
Post Reply