[addon] unit tests fail in master
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Be nice to others! Respect the FreeCAD code of conduct!
[addon] unit tests fail in master
@chennes , I discovered today failing unit tests with the Addon manager:
- open FC and switch to the Test framework WB
- there run the test "TestAddonManagerApp"
result: everything is OK
- re-run the same test
result: you get 5 failures
I think the tests should always pass, no matter how often they are run, right?
- open FC and switch to the Test framework WB
- there run the test "TestAddonManagerApp"
result: everything is OK
- re-run the same test
result: you get 5 failures
I think the tests should always pass, no matter how often they are run, right?
Re: [addon] unit tests fail in master
Yes, definitely. I thought I had cleaned all of that up (when I was first learning to write the tests I had lots of unintended side effects!), but apparently not. I'll give it a look this weekend.
Re: [addon] unit tests fail in master
Why is there no Test Wb in daily windows builds
Re: [addon] unit tests fail in master
Yes both FreeCAD_weekly-builds-32457-2023-03-23-conda-Windows-x86_64-py38.7z and ...-py310.7z don't have it
Re: [addon] unit tests fail in master
I think those intermittent failures are because I'm not waiting long enough for the dialog to open: the goal is to keep each test under 0.1s (per Feathers' advice in Legacy Code), and that's probably not long enough in some cases. For those I'm going to try just adding a bit longer wait before deciding the test has failed. (That failure isn't related to the one Uwe pointed out above).
Re: [addon] unit tests fail in master
@uwestoehr this PR should fix the issue you report: https://github.com/FreeCAD/FreeCAD/pull/9047
Re: [addon] unit tests fail in master
Many thanks. Confirmed fixed.chennes wrote: ↑Sat Mar 25, 2023 3:40 pm @uwestoehr this PR should fix the issue you report: https://github.com/FreeCAD/FreeCAD/pull/9047