major problems after git pull rebuild

Here's the place for discussion related to CAM/CNC and the development of the Path module.
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Post Reply
User avatar
freman
Veteran
Posts: 2200
Joined: Tue Nov 27, 2018 10:30 pm

major problems after git pull rebuild

Post by freman »

I just did git pull and a new build and now I'm getting massive errors where path fail to recompute and I cannot edit jobs or tools .... or just about anything. FreeCAD is totally borked here. . I've tested a couple of backups of the project and they are all now failing.

Code: Select all

23:29:54  Traceback (most recent call last):
  File "/~/freecad-build-master/Mod/Path/PathScripts/PathUtils.py", line 70, in new_function
    res = function(*args, **kwargs)
  File "/~/freecad-build-master/Mod/Path/Path/Op/Base.py", line 828, in execute
    self.job.Proxy.getCycleTime()
  File "/~/freecad-build-master/Mod/Path/Path/Main/Job.py", line 678, in getCycleTime
    if len(self.obj.Operations.Group):
<class 'AttributeError'>: 'ObjectJob' object has no attribute 'obj'
23:29:54  Recompute failed! Please check report view.
reverting to a previous build fix it.

Code: Select all

git reset  f51b2156f3   --hard
I did have a more recent git pull which I have not tested yet , so 5ac308e8a6 was probably the more recent I did before this went wrong.

I have a fix for the peck drilling retraction height bug I reported yesterday, which I why took the risk of doing a git pull, which I now regret.
Syres
Veteran
Posts: 2893
Joined: Thu Aug 09, 2018 11:14 am

Re: major problems after git pull rebuild

Post by Syres »

freman wrote: Thu Mar 23, 2023 5:14 am I did have a more recent git pull which I have not tested yet , so 5ac308e8a6 was probably the more recent I did before this went wrong.
I have an idea what it is and I maybe responsible, now I can prove it, I'll carry out the testing if at fault I'll PR a back-out with Urgent on it.
Syres
Veteran
Posts: 2893
Joined: Thu Aug 09, 2018 11:14 am

Re: major problems after git pull rebuild

Post by Syres »

Yes I was responsible and humbly apologise, back-out PR submitted https://github.com/FreeCAD/FreeCAD/pull/9008
User avatar
freman
Veteran
Posts: 2200
Joined: Tue Nov 27, 2018 10:30 pm

Re: major problems after git pull rebuild

Post by freman »

Wow , you sure know how to make efficiently destructive patches. With just a few lines of code you took out an entire WB ;)

Thanks for recognising the error. Hopefully back-out will get merged without delay.
Last edited by freman on Thu Mar 23, 2023 4:13 pm, edited 1 time in total.
Syres
Veteran
Posts: 2893
Joined: Thu Aug 09, 2018 11:14 am

Re: major problems after git pull rebuild

Post by Syres »

freman wrote: Thu Mar 23, 2023 3:23 pm Hopefully back-out will get merged without delay.
If you're desperate to use the latest master, then in your source folder after the latest git pull, you can use:

Code: Select all

git revert cb2160449412b6470996a2b9b4a4a8ed172d6717
to back-out the faulty commit.
User avatar
freman
Veteran
Posts: 2200
Joined: Tue Nov 27, 2018 10:30 pm

Re: major problems after git pull rebuild

Post by freman »

Thanks for the magic number. I may give that a try since the build I went back to does a core dump when I enter decimal point in the expression editor !!
Last edited by freman on Sat Mar 25, 2023 9:34 pm, edited 1 time in total.
Syres
Veteran
Posts: 2893
Joined: Thu Aug 09, 2018 11:14 am

Re: major problems after git pull rebuild

Post by Syres »

Back out merged git commit 30e815a
User avatar
freman
Veteran
Posts: 2200
Joined: Tue Nov 27, 2018 10:30 pm

Re: major problems after git pull rebuild

Post by freman »

Thanks for the back out PR Syres. I did a new pull and it looks to be back to normal. 8-)
Post Reply