PartDesign Fillet tool

Have some feature requests, feedback, cool stuff to share, or want to know where FreeCAD is going? This is the place.
Forum rules
Be nice to others! Read the FreeCAD code of conduct!
User avatar
Shalmeneser
Veteran
Posts: 9474
Joined: Wed Dec 23, 2020 12:04 am
Location: Fr

Re: PartDesign Fillet tool

Post by Shalmeneser »

Each time you add something (edge/face), is there a check made to know if the fillet will work ?
User avatar
adrianinsaval
Veteran
Posts: 5541
Joined: Thu Apr 05, 2018 5:15 pm

Re: PartDesign Fillet tool

Post by adrianinsaval »

Shalmeneser wrote: Tue Mar 21, 2023 11:33 pm Each time you add something (edge/face), is there a check made to know if the fillet will work ?
There is no way to do that AFAIK, the arguments are just passed to occt once you disable Add mode and it attempts to fillet.
User avatar
Shalmeneser
Veteran
Posts: 9474
Joined: Wed Dec 23, 2020 12:04 am
Location: Fr

Re: PartDesign Fillet tool

Post by Shalmeneser »

I know, but do we need to wait until the end of the action to know if it's ok (someone was speaking of shadowing the result (iterativly ?)).
User avatar
paddle
Veteran
Posts: 1391
Joined: Mon Feb 03, 2020 4:47 pm

Re: PartDesign Fillet tool

Post by paddle »

Actually everytime you add something, the fillet is recomputed. There is even a function that hide the body if it failed :

Code: Select all

void TaskDressUpParameters::hideOnError()
{
    App::DocumentObject* dressup = DressUpView->getObject();
    if (dressup->isError())
        hideObject();
    else
        showObject();
}
So we can use this isError() when something is selected.
User avatar
paddle
Veteran
Posts: 1391
Joined: Mon Feb 03, 2020 4:47 pm

Re: PartDesign Fillet tool

Post by paddle »

PR is ready if you want to try it out : https://github.com/FreeCAD/FreeCAD/pull/8990
Or try with the eyes :
phpBB [video]
chrisb
Veteran
Posts: 53919
Joined: Tue Mar 17, 2015 9:14 am

Re: PartDesign Fillet tool

Post by chrisb »

Big improvement :D !
A Sketcher Lecture with in-depth information is available in English, auf Deutsch, en français, en español.
User avatar
Shalmeneser
Veteran
Posts: 9474
Joined: Wed Dec 23, 2020 12:04 am
Location: Fr

Re: PartDesign Fillet tool

Post by Shalmeneser »

Chapeau bas.
Post Reply