problems with the new CIs

Here's the place for discussion related to coding in FreeCAD, C++ or Python. Design, interfaces and structures.
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
User avatar
uwestoehr
Veteran
Posts: 4961
Joined: Sun Jan 27, 2019 3:21 am
Location: Germany
Contact:

Re: problems with the new CIs

Post by uwestoehr »

openBrain wrote: Sun Feb 05, 2023 7:51 pm "hey, how can we tweak the CI so there's no more this error?". ;)
:D
Here it is stressy that one gets no consistent results, therefore it is hard to see if there is a "real" issue with a PR or something else. My focus is hereby to judge the different PRs.
openBrain wrote: Sun Feb 05, 2023 7:51 pm Are you often running the tests several times on the same code locally too?
Also I guess you're using Windows, which may not suffer same issue.
I use in FreeCAD the Test framework WB. When I e.g. work on FEM code, I run the App and Gui tests for FEM. I thought the CI runs the same.
openBrain
Veteran
Posts: 9034
Joined: Fri Nov 09, 2018 5:38 pm
Contact:

Re: problems with the new CIs

Post by openBrain »

uwestoehr wrote: Sun Feb 05, 2023 7:56 pm :D
Here it is stressy that one gets no consistent results, therefore it is hard to see if there is a "real" issue with a PR or something else. My focus is hereby to judge the different PRs.
This is mainly because both Gitlab and former Github CI didn't run the GUI tests.
The new CI does it and this leads to discovering some issues.
I'm with a mobile now but it looks to me that sporadic error with the GFX driver may also be due to latest changes in StartPage.
Anyway I looked at all runs from the last days and I saw nothing weird except this case.
I use in FreeCAD the Test framework WB. When I e.g. work on FEM code, I run the App and Gui tests for FEM. I thought the CI runs the same.
CI runs all App and Gui tests at each run.
User avatar
wandererfan
Veteran
Posts: 6265
Joined: Tue Nov 06, 2012 5:42 pm
Contact:

Re: problems with the new CIs

Post by wandererfan »

openBrain wrote: Sun Feb 05, 2023 6:42 pm Guess why it fails? Because you merged to master a faulty PR that failed the CI already. As wandererfan rebased on this, of course it fails also.
Thank you. I was having no luck figuring this out on my own.
wmayer
Founder
Posts: 20242
Joined: Thu Feb 19, 2009 10:32 am
Contact:

Re: problems with the new CIs

Post by wmayer »

I think this new PR is an attempt to do so: https://github.com/FreeCAD/FreeCAD/pull/8363
maybe you can have a look?
This is just another workaround for the failing workaround. What I have in mind is to fix the root problem instead -- in case this is possible.
User avatar
Roy_043
Veteran
Posts: 8450
Joined: Thu Dec 27, 2018 12:28 pm

Re: problems with the new CIs

Post by Roy_043 »

wmayer wrote: Mon Feb 06, 2023 9:49 am This is just another workaround for the failing workaround.
No, its a (unit test) workaround for the working (DiffuseColor) workaround.

DiffuseColor issue:
https://github.com/FreeCAD/FreeCAD/issues/8340
wmayer
Founder
Posts: 20242
Joined: Thu Feb 19, 2009 10:32 am
Contact:

Re: problems with the new CIs

Post by wmayer »

No, its a (unit test) workaround for the working (DiffuseColor) workaround.
Sure, but that's the failure we have seen in the CI log file.
User avatar
uwestoehr
Veteran
Posts: 4961
Joined: Sun Jan 27, 2019 3:21 am
Location: Germany
Contact:

Re: problems with the new CIs

Post by uwestoehr »

Roy_043 wrote: Mon Feb 06, 2023 10:22 am No, its a (unit test) workaround for the working (DiffuseColor) workaround.
Sadly this does not fix the problem. Here is another example where it occurs on one CI but in the other one not:
https://github.com/FreeCAD/FreeCAD/pull/8372
openBrain
Veteran
Posts: 9034
Joined: Fri Nov 09, 2018 5:38 pm
Contact:

Re: problems with the new CIs

Post by openBrain »

@uwestoehr I'm gonna re-run the CI for this PR to see how repeatable it is.
So here the direct link to the failing run for future discussions : https://github.com/FreeCAD/FreeCAD/acti ... 7089618557
ATM I'm not sure the crash is caused by "DiffuseColor" test. It hard crashed because of a 'double linked list' which could denote a heap overflow.
User avatar
Roy_043
Veteran
Posts: 8450
Joined: Thu Dec 27, 2018 12:28 pm

Re: problems with the new CIs

Post by Roy_043 »

uwestoehr wrote: Mon Feb 06, 2023 11:26 pm
Roy_043 wrote: Mon Feb 06, 2023 10:22 am No, its a (unit test) workaround for the working (DiffuseColor) workaround.
Sadly this does not fix the problem. Here is another example where it occurs on one CI but in the other one not:
https://github.com/FreeCAD/FreeCAD/pull/8372
Seems OK now: 7 successful checks.
wmayer
Founder
Posts: 20242
Joined: Thu Feb 19, 2009 10:32 am
Contact:

Re: problems with the new CIs

Post by wmayer »

Roy_043 wrote: Tue Feb 07, 2023 8:51 am Seems OK now: 7 successful checks.
It only seems so but in fact it is not. If you check the details of Build2004 and go to the section "FreeCAD GUI tests on install" then it still shows the failure:
https://github.com/FreeCAD/FreeCAD/acti ... ep:15:1091

But what's more weird is that the summary doesn't list any failed tests and instead claims everything is OK.
Post Reply