[Ongoing] Testing Toponaming in upstream FreeCAD

Report observations made with the new Toponaming branch.
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Smiling_user
Posts: 196
Joined: Tue Jul 28, 2020 7:31 am

Re: FreeCAD Contribution Process

Post by Smiling_user »

Tried to test :
in the file attached - changing parts of contour in "Sktch_A" - will cause destruction of whole body.
Trying to reapply sketch "Sktch_B" to same site of "Pad" did not work. [menu>Sketch>Map sketch to face]

Code: Select all

OS: Ubuntu 18.04.6 LTS (KDE/plasma)
Word size of FreeCAD: 64-bit
Version: 0.21.14555 (Git shallow) AppImage
Build type: Release
Branch: development/toponaming
Hash: d2d0b7f01884bf2c8838c07f4389c9e64fc703b5
Python 3.9.13, Qt 5.12.9, Coin 4.0.0, Vtk 9.1.0, OCC 7.5.3
Locale: English/United States (en_US)
Attachments
20221108-toponaming_test_PartDesign.FCStd
(41.71 KiB) Downloaded 108 times
Smiling_user
Posts: 196
Joined: Tue Jul 28, 2020 7:31 am

Re: [Ongoing] Testing Toponaming in upstream FreeCAD

Post by Smiling_user »

Posted somewhere already, that in the attached file changing the contour of Sktch_A results in whole "body" destruction.
Not sure this is a bug, because there is PartDesign used between sketches, but
Toponaming improvements are built it to the core and to the Sketcher and Part workbenches.
only.
Attachments
20221108-toponaming_test_PartDesign.FCStd
(41.71 KiB) Downloaded 110 times
User avatar
adrianinsaval
Veteran
Posts: 5541
Joined: Thu Apr 05, 2018 5:15 pm

Re: [Ongoing] Testing Toponaming in upstream FreeCAD

Post by adrianinsaval »

if it's not for a regression from master branch testing PD is irrelevant right now, the PD portion of toponaming is not yet in the branch.
chrisb
Veteran
Posts: 53919
Joined: Tue Mar 17, 2015 9:14 am

Re: FreeCAD Contribution Process

Post by chrisb »

Smiling_user wrote: Tue Nov 08, 2022 2:11 pm Tried to test :
I have moved your post here. It was in the topic about the contribution process.
A Sketcher Lecture with in-depth information is available in English, auf Deutsch, en français, en español.
Smiling_user
Posts: 196
Joined: Tue Jul 28, 2020 7:31 am

Re: [Ongoing] Testing Toponaming in upstream FreeCAD

Post by Smiling_user »

It's OK:
Idea:
// take elements as geometry primitives( dot, line, 2D-plane inside 3D object), objects as 2D and 3D figures
1. building PD "Body" step by step = system of connected/linked - "condependant" elements and objects.
2. => thus changing previous element changes all descendants
Is it possible to add a new element to description of each element?
it is: after clicking "Close" - each element of currently built object receives index of "topo-name" in terms of general coordinates.
after making changes in some parent object - each element is reindexed for topo-name, identified according to previos topo-names and each descendant
receives binding to reidentified element.
So the new is:
1. identify created elements in terms of general coordinates
2. re-identify created elements after object rebuilt
3. reattach descendants to re-identified elements
ngocminhdao88
Posts: 73
Joined: Wed Nov 11, 2020 10:43 am

Re: [Ongoing] Testing Toponaming in upstream FreeCAD

Post by ngocminhdao88 »

I got this error when opening my file (see attachment). FreeCAD is still working though.

Code: Select all

14:01:07  <Exception> StringHasher.cpp(542): Invalid string table
14:01:07  <Base> Reader.cpp(749): Reading failed from embedded file: StringHasher.Table.txt
FreeCAD info:

Code: Select all

OS: Windows 10 Version 2009
Word size of FreeCAD: 64-bit
Version: 0.20.29382 +85 (Git)
Build type: Release
Branch: development/toponaming
Hash: 51621458b503a7759496e389b1f4a4f02fee8289
Python 3.8.10, Qt 5.15.2, Coin 4.0.1, Vtk 8.2.0, OCC 7.6.3
Locale: German/Germany (de_DE)
Installed mods: 
  * Assembly4 0.12.4
  * CurvedShapes 1.0.4
  * Curves 0.6.4
  * fasteners 0.4.25
  * freecad_metal_workbench 0.0.1
  * lattice2 1.0.0
  * PieMenu 1.2.4
  * QuickMeasure 2022.10.28
  * sheetmetal 0.2.59
Attachments
cooling_air_splitter.FCStd
(299.31 KiB) Downloaded 115 times
User avatar
obelisk79
Veteran
Posts: 1061
Joined: Thu Sep 24, 2020 9:01 pm

Re: [Ongoing] Testing Toponaming in upstream FreeCAD

Post by obelisk79 »

Just following up on this effort and Happy New Year to all!

It seems like progress was quite steady and has slowed down significantly regarding the wait for the final PR integrating TNP mitigation into Part Design for testing. Is there any way those of us interested in testing further can be given an expectation when this branch will be sync'd to master and the final integration merged?

I understand December tends to be a busy time of year full of distractions for those involved, I just hope the enthusiasm behind this effort doesn't die-off before it can be integrated fully.

@realthunder @uwestoehr
jerome992
Posts: 2
Joined: Mon Jan 02, 2023 4:23 pm

Re: [Ongoing] Testing Toponaming in upstream FreeCAD

Post by jerome992 »

I have posted a bug in Sketcher here: https://forum.freecadweb.org/viewtopic. ... 88#p650988
filippor
Posts: 5
Joined: Sat Jan 27, 2018 1:34 pm

Re: [Ongoing] Testing Toponaming in upstream FreeCAD

Post by filippor »

I think this branch Is diverging from master. Why don't periodically merge from master?
lamikr
Posts: 14
Joined: Fri Jul 08, 2022 11:44 pm

Re: [Ongoing] Testing Toponaming in upstream FreeCAD

Post by lamikr »

filippor wrote: Mon Jan 30, 2023 8:24 pm I think this branch Is diverging from master. Why don't periodically merge from master?
It's has been done for a while now. You cam track the progress on

https://github.com/FreeCAD/FreeCAD/issues/8432
Post Reply