Page 2 of 5

Re: please test - Windows build for FreeCAD 0.19.3 available

Posted: Thu Nov 25, 2021 1:26 pm
by adrianinsaval
uwestoehr wrote: Thu Nov 25, 2021 2:33 am Using the latest OCC was my plan but we (the release team consists of sgrogan, loo, syres and me), already run out of spare time.
understandable, thank you all for your work!

Re: please test - Windows build for FreeCAD 0.19.3 available

Posted: Thu Nov 25, 2021 5:45 pm
by keithsloan52
uwestoehr wrote: Thu Nov 25, 2021 2:33 am
adrianinsaval wrote: Wed Nov 24, 2021 9:20 pm any plans of using a newer OCC version? I think 7.5.0 had bugs with step import and/or export that come up every now and then in forum
Using the latest OCC was my plan but we (the release team consists of sgrogan, loo, syres and me), already run out of spare time. So for the maintenance release we rely on pure FreeCAD fixes and keep the Libpack (bundle of third-pary libraries) the same a for FC 0.19.2. We don't want to delay the release again. Once there will be work on the LibPack, we could provide a new maintenance release, maybe only for Windows or Mac since on Linux the third-party libraries are provides by the distribution.

However, for Windows I am trying to update few libraries like GMSH, but not for OCC.
But there are regressions with OCC and STEP processing, FreeCAD 0.19.1 was okay with OCC 7.4.0,
FreeCAD 0.19.2 had OCC 7.5.0 which has the regression(s).

I think it would be better to delay FreeCAD 0.19.3 rather than a second version with the regression.
As @adriansaval points out lots of people have posted about the problems, only available solution is either
FreeCAD 0.19.1 or one of Realthunders build or a FreeCAD 0.20 and therefore little point in releasing FreeCAD 0.19.3 without a fixed version of OCC

Re: please test - Windows build for FreeCAD 0.19.3 available

Posted: Thu Nov 25, 2021 8:54 pm
by uwestoehr
keithsloan52 wrote: Thu Nov 25, 2021 5:45 pm But there are regressions with OCC and STEP processing, FreeCAD 0.19.1 was okay with OCC 7.4.0,
FreeCAD 0.19.2 had OCC 7.5.0 which has the regression(s).
At first to clarify:
- FC is independently developer of OCC, despite we rely on it. So depending on your Distribution, it can be that FC 0.19 is run using OCC 7.4 or 7.5
- for MacOS and Windows we bundle the OCC version with FC
- for FC 0.19 we added an important patch to OCC 7.5. Without this patch FC crashed so oten when dealing with filltets ancd chamfers that it became quite unusable for some users.

For a STEP regression, it is the first time I hear about this.
But I will try to offer a further test build using OCC 7.5.2 but cannot figure out if @chennes' fillet fix is included there.
Chris?

I see in the changelog that the STEP issue is fixed there: https://www.opencascade.com/open-cascad ... e-release/

Besides this I see a brand new release of OCC:
https://dev.opencascade.org/release

The point is that using a new OCC version is a lot of work and of course every new OCC version might have a new regression. Therefore I would not update to OCC 7.6 for our maintenance release.

Re: please test - Windows build for FreeCAD 0.19.3 available

Posted: Thu Nov 25, 2021 9:59 pm
by chennes
We can't use 7.6 anyway, 0.19 won't compile with it and we didn't backport the fixes that make it work on 0.20, so IMO that's a non-starter. It's entirely possible for us to use 7.5.3, but we do need to take care to apply the patchset we used for 7.5.0, since the fillet fix didn't make it into OCC until 7.6.0. The patchset is nicely packaged up for the OCCT MSYS2 package here: https://github.com/msys2/MINGW-packages ... pencascade

Re: please test - Windows build for FreeCAD 0.19.3 available

Posted: Thu Nov 25, 2021 11:52 pm
by chrisb
uwestoehr wrote: Thu Nov 25, 2021 8:54 pm - for FC 0.19 we added an important patch to OCC 7.5. Without this patch FC crashed so oten when dealing with filltets ancd chamfers that it became quite unusable for some users.
...
For a STEP regression, it is the first time I hear about this.
There are quite some posts about the step issue, probably more than we had about fillets in a similar time period. The OCC fix avoids a crash, but doesn't fix the fillet issues, i.e. the fillet will still fail. If it boils down to a decision between correct Step handling vs. fillet crash, I vote for the Step fix.

Re: please test - Windows build for FreeCAD 0.19.3 available

Posted: Fri Nov 26, 2021 4:00 am
by uwestoehr
Here is the next test build:
for FreeCAD 0.19.3:
https://github.com/donovaly/FreeCADInst ... ller-2.exe

It was built using OCC 7.5.2 so the STEP issue shouldn't be there. Please test and report back.

@chennes, I failed to find out if your OCC pathces are included. it seems so since my fillet test case: https://forum.freecadweb.org/viewtopic.php?f=3&t=54353 does not crash.
So am I right and this build contains your fixes?

Re: please test - Windows build for FreeCAD 0.19.3 available

Posted: Fri Nov 26, 2021 4:48 am
by chennes
Did you self-compile OCC or is that from the libpack? I think apeltauer has been applying the blobfish patches to OCC (those include the one I developed, though not the newest version of it).

Re: please test - Windows build for FreeCAD 0.19.3 available

Posted: Fri Nov 26, 2021 8:17 am
by keithsloan52
chennes wrote: Thu Nov 25, 2021 9:59 pm We can't use 7.6 anyway, 0.19 won't compile with it and we didn't backport the fixes that make it work on 0.20
So are there builds of 0.20 that contain OCC 7.6? I just tried the latest weekly build for MacOS 0.20.26479 and it is OCC 7.5.3.
I use the external Python library for Gmsh and need the OCC levels of Gmsh and FreeCAD to match. Gmsh since 4.8.0 is built with
OCC 7.6 and they are now upto Gmsh 4.8.4

Re: please test - Windows build for FreeCAD 0.19.3 available

Posted: Fri Nov 26, 2021 8:45 am
by chrisb
The Step issue doesn't seem to be necessarily connected to OCC 7.5, see https://forum.freecadweb.org/viewtopic. ... 71#p549678 .

Re: please test - Windows build for FreeCAD 0.19.3 available

Posted: Fri Nov 26, 2021 9:14 am
by keithsloan52
chrisb wrote: Fri Nov 26, 2021 8:45 am The Step issue doesn't seem to be necessarily connected to OCC 7.5, see https://forum.freecadweb.org/viewtopic. ... 71#p549678 .
Not sure what was going on given that post but there was definatly a regression on creation of STEP geometry in 7.5 see the 7.5.2 release notes https://www.opencascade.com/open-cascad ... e-release/