Mergers: Removal of icons in UI, after the polls: what now?

Have some feature requests, feedback, cool stuff to share, or want to know where FreeCAD is going? This is the place.
Forum rules
Be nice to others! Read the FreeCAD code of conduct!
Post Reply
User avatar
paddle
Veteran
Posts: 1392
Joined: Mon Feb 03, 2020 4:47 pm

Mergers: Removal of icons in UI, after the polls: what now?

Post by paddle »

Hi there,

Some time ago I opened several polls regarding the removal of some icons from toolbars. Find below the list to the polls.

The results are pretty consensual for some (Snells law, stop operation, 'Select Conflicting/Redundant Constraints', 'Edit Mode' are all about 80% for removal).
And majority is for removal for 'What's this?' and 'Copy' 'Cut' 'Paste' 'Print'.

I don't have merging right in master, so my question is : what now? Who can/want to act following those polls?

- Remove 'Stop Operation' : https://forum.freecadweb.org/viewtopic.php?f=8&t=71922

- Remove 'Select Conflicting/Redundant Constraints' : https://forum.freecadweb.org/viewtopic.php?f=8&t=71923

- Remove 'What's this?' : https://forum.freecadweb.org/viewtopic.php?f=8&t=71926

- Remove 'Copy' 'Cut' 'Paste' 'Print' icons from toolbar : https://forum.freecadweb.org/viewtopic.php?f=8&t=71924

- Remove 'Edit Mode' : https://forum.freecadweb.org/viewtopic.php?f=8&t=71925

- Remove 'Snells law' : https://forum.freecadweb.org/viewtopic.php?f=8&t=71880
chrisb
Veteran
Posts: 53930
Joined: Tue Mar 17, 2015 9:14 am

Re: Mergers: Removal of icons in UI, after the polls: what now?

Post by chrisb »

If you can make pull requests, then Abdullah can merge them. He should have a look anyway.
A Sketcher Lecture with in-depth information is available in English, auf Deutsch, en français, en español.
openBrain
Veteran
Posts: 9034
Joined: Fri Nov 09, 2018 5:38 pm
Contact:

Re: Mergers: Removal of icons in UI, after the polls: what now?

Post by openBrain »

paddle wrote: Mon Oct 03, 2022 10:00 am I don't have merging right in master
Sounds like a good thing, don't you think ? :mrgreen:
so my question is : what now? Who can/want to act following those polls?
As said @chrisb, the only way to be sure something may be done is to do appropriate PR's. ;)
User avatar
adrianinsaval
Veteran
Posts: 5541
Joined: Thu Apr 05, 2018 5:15 pm

Re: Mergers: Removal of icons in UI, after the polls: what now?

Post by adrianinsaval »

chennes removed Snell's Law from toolbar
User avatar
chennes
Veteran
Posts: 3880
Joined: Fri Dec 23, 2016 3:38 pm
Location: Norman, OK, USA
Contact:

Re: Mergers: Removal of icons in UI, after the polls: what now?

Post by chennes »

With small Sketcher PRs I am happy to review and merge -- I leave big/complex/controversial changes to Abdullah, but he's been very busy in his non-FreeCAD life recently.
Chris Hennes
Pioneer Library System
GitHub profile, LinkedIn profile, chrishennes.com
User avatar
paddle
Veteran
Posts: 1392
Joined: Mon Feb 03, 2020 4:47 pm

Re: Mergers: Removal of icons in UI, after the polls: what now?

Post by paddle »

chennes wrote: Mon Oct 03, 2022 5:58 pm With small Sketcher PRs I am happy to review and merge -- I leave big/complex/controversial changes to Abdullah, but he's been very busy in his non-FreeCAD life recently.
Hi Chennes,
I created PR for each of those (not for What's this, as results were no consensual.).
https://github.com/FreeCAD/FreeCAD/pull/7568
https://github.com/FreeCAD/FreeCAD/pull/7569
https://github.com/FreeCAD/FreeCAD/pull/7570
https://github.com/FreeCAD/FreeCAD/pull/7571

They are each 1-2 lines modifications, so pretty basic changes.
Thanks
Post Reply