Missing 2 ViewFit icons in toolbar

Have some feature requests, feedback, cool stuff to share, or want to know where FreeCAD is going? This is the place.
Forum rules
Be nice to others! Read the FreeCAD code of conduct!
User avatar
Kunda1
Veteran
Posts: 13434
Joined: Thu Jan 05, 2017 9:03 pm

Missing 2 ViewFit icons in toolbar

Post by Kunda1 »

Screenshot_20220112_074703.png
Screenshot_20220112_074703.png (27.42 KiB) Viewed 3803 times
Std_ViewFitsAll and Std_ViewFitsSelection icons are missing. I'm confused because i can find their SVGs in the source.

Has this been reported on the forum?

OS: Ubuntu Core 20 (KDE/plasma)
Word size of FreeCAD: 64-bit
Version: 0.20.27054 (Git)
Build type: Release
Branch: master
Hash: 1f70e352a85aafdaaf0cb80e0d3359ec4a2e2dce
Python version: 3.8.10
Qt version: 5.15.3
Coin version: 4.0.0
OCC version: 7.5.2
Locale: English/United States (en_US)
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
User avatar
adrianinsaval
Veteran
Posts: 5541
Joined: Thu Apr 05, 2018 5:15 pm

Re: Missing 2 ViewFit icons in toolbar

Post by adrianinsaval »

Aren't they getting overridden by your system icon theme? Check if there's an icon with that name in your theme. Check Fine-tuning to see how to set FreeCAD to ignore the system icon theme
User avatar
Kunda1
Veteran
Posts: 13434
Joined: Thu Jan 05, 2017 9:03 pm

Re: Missing 2 ViewFit icons in toolbar

Post by Kunda1 »

adrianinsaval wrote: Wed Jan 12, 2022 1:49 pm Aren't they getting overridden by your system icon theme? Check if there's an icon with that name in your theme. Check Fine-tuning to see how to set FreeCAD to ignore the system icon theme
Thanks. I assume you're referring to this parameter?
Bitmaps/Theme/ThemeSearchPaths (boolean): Set to false so FreeCAD uses it's included icons instead of the system icon theme on Linux.
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
User avatar
kaktus
Veteran
Posts: 1174
Joined: Sun Aug 11, 2019 11:59 am
Location: opolskie
Contact:

Re: Missing 2 ViewFit icons in toolbar

Post by kaktus »

The last comment is very factual, however, the lack of icons occurs in different OS, and it is unlikely that everyone is using the same icon theme.
.
Screenshot_20220112_053132.png
Screenshot_20220112_053132.png (89.1 KiB) Viewed 3668 times

OS: Debian GNU/Linux bookworm/sid (KDE/plasma)
Word size of FreeCAD: 64-bit
Version: 0.20.26720 (Git) AppImage
Build type: Release
Branch: (HEAD detached at 7bca26e)
Hash: 7bca26e7c14d4d43374ff7e0c8582735b249cbfd
Python version: 3.9.9
Qt version: 5.12.9
Coin version: 4.0.0
OCC version: 7.5.3
Locale: Polish/Poland (pl_PL)
Twórca polskiej wersji Wiki dla FreeCAD, współwórca polskiej wersji GUI.
"Cierpliwym być musisz, by wiedzę zgłębiać tajemną, gdyż ciemna strona mocy niszczącą i silną jest".
mgr_wojtal
Posts: 1
Joined: Wed Jan 12, 2022 6:30 pm

Re: Missing 2 ViewFit icons in toolbar

Post by mgr_wojtal »

It also looks like this for me.
Image
Attachments
brak polskich liter w menu BIM.png
brak polskich liter w menu BIM.png (68.29 KiB) Viewed 3604 times
Last edited by mgr_wojtal on Wed Jan 12, 2022 6:37 pm, edited 2 times in total.
User avatar
kaktus
Veteran
Posts: 1174
Joined: Sun Aug 11, 2019 11:59 am
Location: opolskie
Contact:

Re: Missing 2 ViewFit icons in toolbar

Post by kaktus »

Kunda1 wrote: Wed Jan 12, 2022 5:42 pm ...
Thanks. I assume you're referring to this parameter?
Bitmaps/Theme/ThemeSearchPaths (boolean): Set to false so FreeCAD uses it's included icons instead of the system icon theme on Linux.
entering this parameter solved the problem, in my case it was absent :idea:
Twórca polskiej wersji Wiki dla FreeCAD, współwórca polskiej wersji GUI.
"Cierpliwym być musisz, by wiedzę zgłębiać tajemną, gdyż ciemna strona mocy niszczącą i silną jest".
User avatar
adrianinsaval
Veteran
Posts: 5541
Joined: Thu Apr 05, 2018 5:15 pm

Re: Missing 2 ViewFit icons in toolbar

Post by adrianinsaval »

Kunda1 wrote: Wed Jan 12, 2022 5:42 pm Thanks. I assume you're referring to this parameter?
Bitmaps/Theme/ThemeSearchPaths (boolean): Set to false so FreeCAD uses it's included icons instead of the system icon theme on Linux.
yes
kaktus wrote: Wed Jan 12, 2022 6:17 pm the lack of icons occurs in different OS, and it is unlikely that everyone is using the same icon theme.
Not at all, you're both using KDE just with different distros, and even the distros are similar since ubuntu is based on debian, the most likely things is that you are using the same icon theme or a derivative of it (there's a ton of breeze variants with different colors in the kde store)
entering this parameter solved the problem, in my case it was absent :idea:
yes this is normal, most of these parameters need to be created by the user if he wants to change the behavior and the program uses the default value if the parameter is absent.
User avatar
kaktus
Veteran
Posts: 1174
Joined: Sun Aug 11, 2019 11:59 am
Location: opolskie
Contact:

Re: Missing 2 ViewFit icons in toolbar

Post by kaktus »

Yes yes but I have spoken to one friend in the meantime, I expect he has a completely different configuration.

I also took note of KDE.

Edit:

I see that he also pasted his picture, but did not write anything about the distribution he is using.
Twórca polskiej wersji Wiki dla FreeCAD, współwórca polskiej wersji GUI.
"Cierpliwym być musisz, by wiedzę zgłębiać tajemną, gdyż ciemna strona mocy niszczącą i silną jest".
User avatar
adrianinsaval
Veteran
Posts: 5541
Joined: Thu Apr 05, 2018 5:15 pm

Re: Missing 2 ViewFit icons in toolbar

Post by adrianinsaval »

oh I missed mgr_wojtal's post somehow :oops: either way it's the same thing, an icon from the system theme is used. It would be nice if FreeCAD prioritized it's own icons over the system's theme or if that parameter did this instead of entirely removing the possibility of using system icons since the file dialog is missing many icons specific to certain folders
User avatar
Kunda1
Veteran
Posts: 13434
Joined: Thu Jan 05, 2017 9:03 pm

Re: Missing 2 ViewFit icons in toolbar

Post by Kunda1 »

Sorry, feeling obtuse here, but can you help me understand what is happening by default?
What needs to change in FC core to make this behavior disappear without fully deferring to the DE the user is using ?
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
Post Reply