[FIXED] Ticket #4451: cant open Openscad file *.scad

[Kunda1]

Discussion thread for issue #4451: cant open Openscad file *.scad

[jmaustpc]

From the ticket

if i try open some scad files with operation hull it will not successfully ended but traceback is

ping

Hi Keith, I wonder if you would be interested in looking at this? No pressure, just thought you might.

JIm

[sgrogan]

Discussion thread for issue #4451: cant open Openscad file *.scad

Hi Keith, I wonder if you would be interested in looking at this? No pressure, just thought you might.

Anyone have a test .scad file where this fails.
The current https://github.com/FreeCAD/FreeCAD/blam ... es.py#L502 import looks like a new style "namespace" import but the OpenSCAD WB hasn't been ported to this style.
The reporter's fix appears valid, but I don't have a .scad file using "hull" to test.

[jmaustpc]

Discussion thread for issue #4451: cant open Openscad file *.scad

Hi Keith, I wonder if you would be interested in looking at this? No pressure, just thought you might.

Anyone have a test .scad file where this fails.
The current https://github.com/FreeCAD/FreeCAD/blam ... es.py#L502 import looks like a new style "namespace" import but the OpenSCAD WB hasn't been ported to this style.
The reporter's fix appears valid, but I don't have a .scad file using "hull" to test.

Is this one suitable? It was attached to the ticket, I think you would have noticed so I suspect isn't suitable?

I downloaded it and then attached it to this post.

hull.scad

(68 Bytes) Downloaded 40 times

Jim

[keithsloan52]

Discussion thread for issue #4451: cant open Openscad file *.scad

Hi Keith, I wonder if you would be interested in looking at this? No pressure, just thought you might.

Anyone have a test .scad file where this fails.
The current https://github.com/FreeCAD/FreeCAD/blam ... es.py#L502 import looks like a new style "namespace" import but the OpenSCAD WB hasn't been ported to this style.
The reporter's fix appears valid, but I don't have a .scad file using "hull" to test.

I have a new style namespace version of the OpenSCAD WB in my GitHub repro ( Now made private) and it appears OpenSCADFeatures.py got contaminated with some code from it, sorry about that.

[keithsloan52]

Discussion thread for issue #4451: cant open Openscad file *.scad

Hi Keith, I wonder if you would be interested in looking at this? No pressure, just thought you might.

Anyone have a test .scad file where this fails.
The current https://github.com/FreeCAD/FreeCAD/blam ... es.py#L502 import looks like a new style "namespace" import but the OpenSCAD WB hasn't been ported to this style.
The reporter's fix appears valid, but I don't have a .scad file using "hull" to test.

I have a new style namespace version of the OpenSCAD WB in my GitHub repro ( Now made private) and it appears OpenSCADFeatures.py got contaminated with some code from it, sorry about that.

[raymw]

Hi, Importing the hull.scad file, I get this

19:52:00 Traceback (most recent call last):
File "C:\Users\Ray\freecad19\FreeCAD_0.19.22284-Win-Conda_vc14.x-x86_64\Mod\OpenSCAD\OpenSCADFeatures.py", line 502, in execute
import Part, freecad.OpenSCAD.OpenSCADUtils
<class 'ModuleNotFoundError'>: No module named 'freecad.OpenSCAD'

I get the same for importing a minkowski

Code: Select all

$fn =50;
minkowski() {
    cube([10, 10, 1]);
	cylinder(1);
 }

All the main components cube/sphere/cylinder are imported OK, but the fiddly bits seem to fail. (I find it quicker to rough out the shape in openscad, import to freecad for filleting and otherwise finish, and export as stl. Exporting back to openscad for further editing is very iffy.
Best Wishes, Ray

[sgrogan]

I have a new style namespace version of the OpenSCAD WB in my GitHub repro ( Now made private) and it appears OpenSCADFeatures.py got contaminated with some code from it, sorry about that.

Are you going to make a pull request. I can if you don't have time.

[keithsloan52]

I have a new style namespace version of the OpenSCAD WB in my GitHub repro ( Now made private) and it appears OpenSCADFeatures.py got contaminated with some code from it, sorry about that.

Are you going to make a pull request. I can if you don't have time.

Have a lot on my plate at the moment, eldest daughter passed her due date etc etc, so if you could do it that would be great.

[sgrogan]

Have a lot on my plate at the moment, eldest daughter passed her due date etc etc

Good luck and best wishes!
pull/3971