Feature #1190: Polar pattern doesn't obey UpToFirst/UpToLast/UpToFace pad features

Have some feature requests, feedback, cool stuff to share, or want to know where FreeCAD is going? This is the place.
Forum rules
Be nice to others! Read the FreeCAD code of conduct!
User avatar
Kunda1
Veteran
Posts: 13443
Joined: Thu Jan 05, 2017 9:03 pm

Feature #1190: Polar pattern doesn't obey UpToFirst/UpToLast/UpToFace pad features

Post by Kunda1 »

issue #1190 Polar pattern doesn't obey UpToFirst/UpToLast/UpToFace pad features
Please weigh in on this feature request. Should we keep it in the tracker?
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
chrisb
Veteran
Posts: 52169
Joined: Tue Mar 17, 2015 9:14 am

Re: Feature #1190: Polar pattern doesn't obey UpToFirst/UpToLast/UpToFace pad features

Post by chrisb »

I did not miss it until now but it still sounds reasonable. Of course it would need something like an extra checkbox to activate this behaviour.
A Sketcher Lecture with in-depth information is available in English, auf Deutsch, en français, en español.
User avatar
Kunda1
Veteran
Posts: 13443
Joined: Thu Jan 05, 2017 9:03 pm

Re: Feature #1190: Polar pattern doesn't obey UpToFirst/UpToLast/UpToFace pad features

Post by Kunda1 »

chrisb wrote: Thu May 31, 2018 9:24 am I did not miss it until now but it still sounds reasonable. Of course it would need something like an extra checkbox to activate this behaviour.
Whats a better name for this ticket if we're considering it a Feature Request?
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
chrisb
Veteran
Posts: 52169
Joined: Tue Mar 17, 2015 9:14 am

Re: Feature #1190: Polar pattern doesn't obey UpToFirst/UpToLast/UpToFace pad features

Post by chrisb »

Kunda1 wrote: Fri Jan 04, 2019 6:59 pm Whats a better name for this ticket if we're considering it a Feature Request?
I don't think there is much to change, perhaps make it positive

Option for PolarPattern to obey individual UpToFirst/UpToLast/UpToFace pad features for each instance.
A Sketcher Lecture with in-depth information is available in English, auf Deutsch, en français, en español.
User avatar
Kunda1
Veteran
Posts: 13443
Joined: Thu Jan 05, 2017 9:03 pm

Re: Feature #1190: Polar pattern doesn't obey UpToFirst/UpToLast/UpToFace pad features

Post by Kunda1 »

chrisb wrote: Fri Jan 04, 2019 10:29 pm Option for PolarPattern to obey individual UpToFirst/UpToLast/UpToFace pad features for each instance.
Renamed ticket. Thanks @chrisb :)
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
User avatar
jnxd
Posts: 929
Joined: Mon Mar 30, 2015 2:30 pm
Contact:

Re: Feature #1190: Polar pattern doesn't obey UpToFirst/UpToLast/UpToFace pad features

Post by jnxd »

@Kunda1 could you rename this thread to reflect the github issue?

If I understand this correctly, this will involve a fundamental change in the way patterns are implemented in FC. Currently, it is done in the following way
  • The individual feature generates add/sub shapes while making the shape after the feature is applied.
  • The pattern feature then transforms these add/sub shapes and applies them on the "parent".
For this request to work, the individual PD features will have to be applied directly after applying transformations on the preliminaries (for example on the sketch and direction of a pad). This in turn will need some changes to how the PD feature's "execute" works, since it is makes heavy use of it's "properties".
My latest (or last) project: B-spline Construction Project.
Jee-Bee
Veteran
Posts: 2568
Joined: Tue Jun 16, 2015 10:32 am
Location: Netherlands

Re: Feature #1190: Polar pattern doesn't obey UpToFirst/UpToLast/UpToFace pad features

Post by Jee-Bee »

chrisb wrote: Thu May 31, 2018 9:24 am Of course it would need something like an extra checkbox to activate this behaviour.
Please follow the methods also used in PD Pad. I prefer that it has compareble working methods and not that every tool have a different solution for a comparable problem...
User avatar
jnxd
Posts: 929
Joined: Mon Mar 30, 2015 2:30 pm
Contact:

Re: Feature #1190: Polar pattern doesn't obey UpToFirst/UpToLast/UpToFace pad features

Post by jnxd »

Jee-Bee wrote: Thu Jul 21, 2022 6:24 am
chrisb wrote: Thu May 31, 2018 9:24 am Of course it would need something like an extra checkbox to activate this behaviour.
Please follow the methods also used in PD Pad. I prefer that it has compareble working methods and not that every tool have a different solution for a comparable problem...
Could you elaborate?
My latest (or last) project: B-spline Construction Project.
Jee-Bee
Veteran
Posts: 2568
Joined: Tue Jun 16, 2015 10:32 am
Location: Netherlands

Re: Feature #1190: Polar pattern doesn't obey UpToFirst/UpToLast/UpToFace pad features

Post by Jee-Bee »

I try...

What i don't like is that quite often (FC, Creo, SW, probably all others too) there are (sometimes big )difference in workflows between the different tools, while (some of )their function is quite often similar or extensions of each other(example a loft and a loft following a path).
What my point is in this case: Pad Already have a workflow where it extend to a point. There is some discussion to add this too to Revolve. I think it is good to look there so that all the UpTo... have a similar workflow.

One other point i want to make. A few months back there was a topic about add the option to set step size and then the number of holes. I think this request is more useful with that approach as with current implementation.
User avatar
adrianinsaval
Veteran
Posts: 5414
Joined: Thu Apr 05, 2018 5:15 pm

Re: Feature #1190: Polar pattern doesn't obey UpToFirst/UpToLast/UpToFace pad features

Post by adrianinsaval »

I don't see how any of that is relatwd to this request.
jnxd wrote: Thu Jul 21, 2022 6:12 am For this request to work, the individual PD features will have to be applied directly after applying transformations on the preliminaries (for example on the sketch and direction of a pad). This in turn will need some changes to how the PD feature's "execute" works, since it is makes heavy use of it's "properties".
I'm not sure if this would be a good idea, many times the selected face would not be a valid limit for the transformed copies, besides this would most likely result in a significant performance hit
Post Reply