Ticket #5707: VRML - 2 crashes with corner cases

[Kunda1]

issue #5707: VRML 2 crashes with corner cases
Forum thread for discussion.

[Kunda1]

@kwahoo do you mind testing to this if issue #5707 is still relevant?

[kwahoo]

@kwahoo do you mind testing to this if issue #5707 is still relevant?

Unfortunately, I'm not able to download the files from Mantis (0 byte size) and they are not migrated to Github

[Kunda1]

Unfortunately, I'm not able to download the files from Mantis

The files don't work in
https://tracker.freecad.org/view.php?id=3070 ?

[adrianinsaval]

Many files in the mantis tracker don't work

[kwahoo]

The files don't work in
https://tracker.freecad.org/view.php?id=3070 ?

Exactly these files.

[wmayer]

Unfortunately, I cannot find a copy of the files on my disk any more but according to the file names it should be possible to restore the defects of their contents:

• corrupts memory - name too long.wrl -- a VRML2 file with a very long name of a DEF
• corrupts memory - name too long (VRML 1).wrl -- the same for a VRML1 file
• crash - recursive USE.wrl -- a recursive USE definition for a VRML2 file
• crash - recursive USE (VRML 1).wrl -- the same for a VRML1 file
• crash - recursive PROTO.wrl -- a recursive PROTO definition

[wmayer]

crash - recursive PROTO.wrl:

Code: Select all

#VRML V2.0 utf8
#
# Test case for recursive PROTO definitions. Undefined per specification, but the program should not lifelock in any case.
#
#  T H I S   F I L E   S H O U L D   N O T   R U N


PROTO Recursive [] {
	Group {
		children [
			Recursive { }
		]
	}
}

Recursive { }

crash - recursive USE.wrl:

Code: Select all

#VRML V2.0 utf8
#
# Test case for “USE” of a node in itself (undefined per specification). The program must not lifelock under any circumstances.
# In this test, the recursion is second-level (catches naïve implementations).
#
#   S H O U L D   D I S P L A Y   A   G R E E N   S P H E R E !


DEF recursive Group{
	children [

		Group{
			children [

				USE recursive

			]
		}

	]
}

crash - recursive USE (VRML 1).wrl:

Code: Select all

#VRML V1.0 ascii


DEF recursive Group {
	Group {
		USE recursive
	}
}

So far the crash is fixed for: crash - recursive USE.wrl and crash - recursive USE (VRML 1).wrl