That would be good, but, most often, then the files are too big to post here...adrianinsaval wrote: ↑Thu Oct 27, 2022 5:55 pm please use webp or some other video format, gif is very hard to follow because there's no start/end reference.
[Ongoing] Testing Toponaming in upstream FreeCAD
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Be nice to others! Respect the FreeCAD code of conduct!
Re: [Ongoing] Testing Toponaming in upstream FreeCAD
Star Trek II: The Wrath of Khan: Spock: "...His pattern indicates two-dimensional thinking."
Re: [Ongoing] Testing Toponaming in upstream FreeCAD
With this comment I think it is clear what is your point.
I would say the following:
The RT TPN algo is not able to fix any broken link/attachment. But it never claimed it can.
The real question is: "does it anyway bring a real improvement in solving TPN problem ?" And how ?
Looking at https://github.com/realthunder/FreeCAD_ ... -Algorithm it seems to me that the mapped name of faces are composed of two part: a first part which identify the fature (in example a PAD) to which the face belongs and a last part (faceN) in which the index N is generated in a randomic way.
This reduces the ambiguity with respect to OCC indexes because the mapped name is stricly related with the PAD. When you change the pad sketch the indeces of the pad faces are regenerated. Therefore the attachment of a second sketch may switch to a different face. But, at least, it is granted that the new attachment face must belongs to the same PAD.
This is just my thought and I am not very sure of what I am saying. I would like to have a confirmation from RT.
Re: [Ongoing] Testing Toponaming in upstream FreeCAD
Maybe I'm not being clear.
RT wrote previously in this thread:
That, to me implies the TNP mitigation code has been merged for Part module (so for Part workbench as well???).The team agree to make formal release for the toponaming branch in its current state first (very soon). And if no major problems reported by other developers, then I'll add the PartDesign patch.
My example shows TNP happening in a Part workbench model.There are no Part Design workbench anything in the video (check the treeview).
The video was done with topo branch git source code from that day. (I just tested with git 0.20.29382 with the same results.)
Star Trek II: The Wrath of Khan: Spock: "...His pattern indicates two-dimensional thinking."
Re: [Ongoing] Testing Toponaming in upstream FreeCAD
No. You were clear. You have shown a TPN issue affecting the Part WB that it is not fixed by RT TPN Algo (even if Part WB code of TPN has already been merged).
My considerations were on what can realistically be (automatically) fixed and what can not. And I think that the problem you are showing can not.
Re: [Ongoing] Testing Toponaming in upstream FreeCAD
The steps I demonstrate seem to work fine in the RT branch.wsteffe wrote: ↑Fri Oct 28, 2022 2:21 pmNo. You were clear. You have shown a TPN issue affecting the Part WB that it is not fixed by RT TPN Algo (even if Part WB code of TPN has already been merged).
My considerations were on what can realistically be (automatically) fixed and what can not. And I think that the problem you are showing can not.
Star Trek II: The Wrath of Khan: Spock: "...His pattern indicates two-dimensional thinking."
- adrianinsaval
- Veteran
- Posts: 5553
- Joined: Thu Apr 05, 2018 5:15 pm
Re: [Ongoing] Testing Toponaming in upstream FreeCAD
it's worth reporting and asking for realthunder's opinion on the matter but it might be better to report here: https://forum.freecadweb.org/viewtopic.php?f=10&t=72886
-
- Veteran
- Posts: 3192
- Joined: Thu Sep 24, 2020 10:31 pm
- Location: Hawaii
- Contact:
Re: [Ongoing] Testing Toponaming in upstream FreeCAD
Is the forum set up for webp? I just tried to attach one to a post and its selection was greyed out. How about the wiki?adrianinsaval wrote: ↑Thu Oct 27, 2022 5:55 pm please use webp or some other video format, gif is very hard to follow because there's no start/end reference.
Ed
- adrianinsaval
- Veteran
- Posts: 5553
- Joined: Thu Apr 05, 2018 5:15 pm
Re: [Ongoing] Testing Toponaming in upstream FreeCAD
I meant webm, you can attach it but unfortunately it isn't show with an embedded player, one has to download to see it. If you uploaded it somewhere else the
tag should work to show an embedded player.
Code: Select all
[video][/video]
-
- Veteran
- Posts: 3192
- Joined: Thu Sep 24, 2020 10:31 pm
- Location: Hawaii
- Contact:
Re: [Ongoing] Testing Toponaming in upstream FreeCAD
I can open this link in my browser, but it doesn't seem to work embedded. @adrianinsaval Do I need to do something else?
https://www.dropbox.com/s/ylfaxeo9hw1kb ... .webm?dl=0
EDIT:
Answered here: https://forum.freecadweb.org/viewtopic. ... 05#p637305