[Ongoing] Testing Toponaming in upstream FreeCAD

Report observations made with the new Toponaming branch.
User avatar
mfro
Posts: 357
Joined: Sat Sep 23, 2017 8:15 am

Re: [Ongoing] Testing Toponaming in upstream FreeCAD

Post by mfro »

wsteffe wrote: Sat Sep 17, 2022 8:22 am Regarding the L-Profile constraint, I think that now, after merging of toponaming3 which provides support for sketch, the problem is solved also in branch development/toponaming.
Tried that as well yesterday and can confirm it's fine now.
Cheers,
Markus
wsteffe
Posts: 367
Joined: Thu Aug 21, 2014 8:17 pm

Re: [Ongoing] Testing Toponaming in upstream FreeCAD

Post by wsteffe »

adrianinsaval wrote: Thu Sep 15, 2022 8:55 pm part extrude with taper angle works incorrectly (nested profiles are filled)
I have just checked that this bug persists after merging of toponaming3. I have also seen that it affects also the current RT branch LinkDaily. So I do not expect it can be fixed in the next PR (toponaming4).

It seems that this bug was actually introduced by toponaming related PRs. The only other possibility is that it was preexisting but fixed in a recent Master Commit not yet included in currrent development/toponaming and in RT/LinkDaily.
adrianinsaval
Veteran
Posts: 3590
Joined: Thu Apr 05, 2018 5:15 pm

Re: [Ongoing] Testing Toponaming in upstream FreeCAD

Post by adrianinsaval »

I doubt that, it was working fine in 0.20 and later IIRC
wsteffe
Posts: 367
Joined: Thu Aug 21, 2014 8:17 pm

Re: [Ongoing] Testing Toponaming in upstream FreeCAD

Post by wsteffe »

adrianinsaval wrote: Sun Sep 18, 2022 3:26 pm I doubt that
But it is also quite strange that this kind of bug can be caused by the topo-naming stuff: It works fine with angle=0 while it fails with angle>0. The topology is the same in both cases.
adrianinsaval
Veteran
Posts: 3590
Joined: Thu Apr 05, 2018 5:15 pm

Re: [Ongoing] Testing Toponaming in upstream FreeCAD

Post by adrianinsaval »

the extrusion algorithm is not the same for both cases, for angle=0 it directly uses a extrusion function from occt, when there is a taper angle it has to use different occt functions, I suspect there was some conflict there, realthunder had his own extrusion taper implementation, perhaps some of that got mixed in and causes trouble.
realthunder
Veteran
Posts: 2167
Joined: Tue Jan 03, 2017 10:55 am

Re: [Ongoing] Testing Toponaming in upstream FreeCAD

Post by realthunder »

PR submitted for the taper angle problem. The topo naming enabled algorithm is what originally implemented before the upstream version. I choose to retain it because it problem extra function like independent outer and inner tapper angles (for holes). The PR fixed the backward compatibility by adding a new property AutoTaperInnerAngle defaults to True, which will auto fill the inner taper angle as the negative of outer one which is the same behavior as upstream master.
Try Assembly3 with my custom build of FreeCAD at here.
And if you'd like to show your support, you can donate through patreon, liberapay, or paypal
lamikr
Posts: 7
Joined: Fri Jul 08, 2022 11:44 pm

Re: [Ongoing] Testing Toponaming in upstream FreeCAD

Post by lamikr »

I did a git pull but did not see the fix in development/totonaming branch.
User avatar
Kunda1
Veteran
Posts: 13011
Joined: Thu Jan 05, 2017 9:03 pm

Re: [Ongoing] Testing Toponaming in upstream FreeCAD

Post by Kunda1 »

@lamikr hasn't been merged yet. ;)
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
#lowhangingfruit | Use the Source, Luke. | How to Help FreeCAD | How to report FC bugs and features
Post Reply