[TD] Projection group, X/Y spacing

Discussions about the development of the TechDraw workbench
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Post Reply
balrobs
Posts: 449
Joined: Fri Apr 24, 2020 8:58 pm

[TD] Projection group, X/Y spacing

Post by balrobs »

In the German forum there was a discussion about X/Y spacing from group view.
So I realized that X/Y spacing gives me unexpected results.

Steps to reproduce:
- in Part WB create a cube 40x40x40mm
- change 3d view to Front
- in TD WB insert a new default page
- select the cube and insert a new Projection group
- in the task dialog for the secondary projections select left, right, top and bottom. For both X and Y spacing choose zero.
- I see this expected result
Cube_01.png
Cube_01.png (5.54 KiB) Viewed 786 times
- now change the box height to 60mm leaving X and Y spacing at zero and recompute the page
- this is my unexpected result
Cube_02.png
Cube_02.png (6.28 KiB) Viewed 786 times
- and this is what I would expect
Cube_03.png
Cube_03.png (6.25 KiB) Viewed 786 times
Am I missing something here or can this be considered to be a bug?

Edit: Forgot to append my system info:

Code: Select all

OS: Ubuntu Core 20 (ubuntu:GNOME/ubuntu)
Word size of FreeCAD: 64-bit
Version: 0.21.30338 (Git) Snap 275
Build type: Release
Branch: master
Hash: b97c93008ecdee4402025c4bc2f2b5b0a9ffafc9
Python 3.8.10, Qt 5.15.5, Coin 4.0.0, Vtk 7.1.1, OCC 7.6.3
Locale: English/United States (en_US)
Installed mods: 
  * BIM 2021.12.0
  * Behave-Dark-Colors 0.1.1
  * ProDarkThemePreferencePack 1.0.0
  * FEM_FrontISTR 0.1.0
  * lattice2 1.0.0
  * ExtremeProDark 1.0.3
  * Dracula 0.0.2
  * Help 1.0.3
User avatar
wandererfan
Veteran
Posts: 6270
Joined: Tue Nov 06, 2012 5:42 pm
Contact:

Re: [TD] Projection group, X/Y spacing

Post by wandererfan »

balrobs wrote: Sat Sep 10, 2022 7:21 am So I realized that X/Y spacing gives me unexpected results.
The current code uses the tallest row for vertical spacing and the widest column for horizontal spacing. I'll change it to use tallest in each row and widest in each column.
User avatar
wandererfan
Veteran
Posts: 6270
Joined: Tue Nov 06, 2012 5:42 pm
Contact:

Re: [TD] Projection group, X/Y spacing

Post by wandererfan »

balrobs wrote: Sat Sep 10, 2022 7:21 am So I realized that X/Y spacing gives me unexpected results.
Should be fixed by git commit ec9d256d0e
balrobs
Posts: 449
Joined: Fri Apr 24, 2020 8:58 pm

Re: [TD] Projection group, X/Y spacing

Post by balrobs »

Thanks @wandererfan ... I appreciate your way of responding to requests very much :D
No unnecessary chatter but quick an focused action.
It will be my pleasure to test your change and give you feedback.
Greetings
balrobs
Posts: 449
Joined: Fri Apr 24, 2020 8:58 pm

Re: [TD] Projection group, X/Y spacing

Post by balrobs »

balrobs wrote: Sun Sep 11, 2022 7:08 am It will be my pleasure to test your change and give you feedback.
Works as expected
Thanks :D
Post Reply