TechDraw ExtensionSelectLineAttributes possible issue

Discussions about the development of the TechDraw workbench
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Post Reply
Workshop_Notes
Posts: 590
Joined: Wed Sep 29, 2021 8:35 am

TechDraw ExtensionSelectLineAttributes possible issue

Post by Workshop_Notes »

I am not sure if there is an issue with the above, or if I am using it incorrectly. Could someone please try to reproduce.

In PartDesign, draw a circle and pad it.
Bring it into a TechDraw view and apply quadrant cosmetic vertices.
Draw a vertical cosmetic line between two of the vertices. It appears as the standard thin, black dashed line.
Click TechDraw ExtensionSelectLineAttributes and select a set of different attributes (e.g. solid green) and OK.

Now draw a horizontal cosmetic line between the two vertices. It still appears thin, black and dashed. The pop-up explanatory text for the Attributes command says it is for "new" lines, but that does not seem to be so.

Select the horizontal line and click TechDraw ExtensionChangeLineAttributes. The line now gains the solid green attributes.

Draw another cosmetic line at 45 degrees between any two points. It still appears dashed and black. Change it to solid green using the ChangeLineAttributes button. It does indeed change. Now hit undo - the whole line disappears, not merely a reversion of the attribute change.

Make a cosmetic line red and solid. Then change it to green and dash-dot. Now hit undo. Nothing happens.

This behaviour is non-intuitive and does not match the description of the commands. Right now the Select button is just acting as something you have to do before pressing the Change button. The two buttons together seem to do the same as TechDrawDecorate line and need an extra mouse click to do it. Undo also does not seem to work with TechDrawDecorate.

---
OS: Windows 10 Version 2009
Word size of FreeCAD: 64-bit
Version: 0.20.27422 (Git)
Build type: Release
Branch: master
Hash: d938733eaf2c2ce7cb18d1cbb56147185c473530
Python version: 3.8.6+
Qt version: 5.15.2
Coin version: 4.0.1
OCC version: 7.5.3
Locale: English/United Kingdom (en_GB)
User avatar
Roy_043
Veteran
Posts: 8450
Joined: Thu Dec 27, 2018 12:28 pm

Re: TechDraw ExtensionSelectLineAttributes possible issue

Post by Roy_043 »

The Extensions tools are a new addition. Only new cosmetic lines and centerlines created with the Extensions tools use these settings at the moment.
edi
Posts: 481
Joined: Fri Jan 17, 2020 1:32 pm

Re: TechDraw ExtensionSelectLineAttributes possible issue

Post by edi »

The old (version 0.19) line creating tools: https://wiki.freecadweb.org/TechDraw_FaceCenterLine etc. and https://wiki.freecadweb.org/TechDraw_2PointCosmeticLine have been adopted to version 0.20 without changes in their user interface .

Using the extension tool https://wiki.freecadweb.org/TechDraw_Ex ... Attributes you have the possibility to change attributes which have been created using these "old" tools after their creation.

The extension tools work with all centerlines and cosmetic lines, independent which tool created them.

When creating new lines using extension tools, the attributes preselected in https://wiki.freecadweb.org/TechDraw_Ex ... Attributes are used automatic
Workshop_Notes
Posts: 590
Joined: Wed Sep 29, 2021 8:35 am

Re: TechDraw ExtensionSelectLineAttributes possible issue

Post by Workshop_Notes »

Roy_043 wrote: Sun Apr 24, 2022 8:06 am The Extensions tools are a new addition. Only new cosmetic lines and centerlines created with the Extensions tools use these settings at the moment.
So please could the Wiki page (https://wiki.freecadweb.org/TechDraw_Ex ... Attributes) be slightly edited to clarify this.

What is says now is strictly correct "where you can select the attributes (style, width and color) for new cosmetic lines and centerlines created with the Extensions tools" but it is either not strong enough (it works ONLY with new lines created using Extensions tools) or needs specifically to exclude standard cosmetic lines.

The tooltip that pops up when you hover over the button is worse than the Wiki as there is no mention of its scope (maybe we are to infer its scope due to its colour).

Is it on the roadmap to make the undo aware of attribute changes?
User avatar
Roy_043
Veteran
Posts: 8450
Joined: Thu Dec 27, 2018 12:28 pm

Re: TechDraw ExtensionSelectLineAttributes possible issue

Post by Roy_043 »

Workshop_Notes wrote: Wed Apr 27, 2022 8:06 am Is it on the roadmap to make the undo aware of attribute changes?
Look for "PropertyView/AutoTransactionView" on the Fine-tuning page.
Post Reply