[Feature Request] Surface finish symbols [SOLVED]
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Be nice to others! Respect the FreeCAD code of conduct!
Re: [Feature Request] Surface finish symbols
The tool has been merged and will be available in the next weekly version.
Documentation in wiki see: https://wiki.freecadweb.org/TechDraw_Su ... nishSymbol
@domad: thank you for creating the icon.
@wandererfan: thank you for merging quickly and forgiving my git-ignorance.
@NewJoker: please mark this thread as "solved".
Documentation in wiki see: https://wiki.freecadweb.org/TechDraw_Su ... nishSymbol
@domad: thank you for creating the icon.
@wandererfan: thank you for merging quickly and forgiving my git-ignorance.
@NewJoker: please mark this thread as "solved".
Re: [Feature Request] Surface finish symbols [SOLVED]
@edi Thank you so much, it's a wonderful addition to TechDraw
I marked this thread as solved. I will also close the GitHub issue and add information to the release notes.
P.S. To use the new mentioning functionality on the forum, you have to choose a username from the list that appears once you start typing after @.
I marked this thread as solved. I will also close the GitHub issue and add information to the release notes.
P.S. To use the new mentioning functionality on the forum, you have to choose a username from the list that appears once you start typing after @.
- wandererfan
- Veteran
- Posts: 6317
- Joined: Tue Nov 06, 2012 5:42 pm
- Contact:
Re: [Feature Request] Surface finish symbols
I made some comments before I merged, but they seem to have disappeared. As best I remember:
- the drop down for RA is obscured by another widget in some cases and loses the top of the list in others.
- the decimal separator in RA should conform to the locale. It looks to be hard coded as ","
- the shadows/background on the widgets don't look right here. Maybe they look right with another stylesheet.
Minor issues only.
Thanks for this addition.
Re: [Feature Request] Surface finish symbols
Is the tool alredy merged in the weekly version 29485-2022-07-28?edi wrote: ↑Fri Jul 22, 2022 7:26 am The tool has been merged and will be available in the next weekly version.
Documentation in wiki see: https://wiki.freecadweb.org/TechDraw_Su ... nishSymbol
@domad: thank you for creating the icon.
@wandererfan: thank you for merging quickly and forgiving my git-ignorance.
@NewJoker: please mark this thread as "solved".
I can't find tool in teckDraw!
Thanks Luca
- wandererfan
- Veteran
- Posts: 6317
- Joined: Tue Nov 06, 2012 5:42 pm
- Contact:
Re: [Feature Request] Surface finish symbols
I would say not yet. Should be there soon, but I'm not sure when the weekly gets built.
It was merged to master branch ~2022-07-20. It is not present this version, which is newer than yours.
Code: Select all
OS: Linux Mint 20.3 (X-Cinnamon/cinnamon)
Word size of FreeCAD: 64-bit
Version: 0.21.29603 (Git)
Build type: debug
Branch: master
Hash: 094ae9367837901fa94a251ed684f2f3de141be0
Python 3.8.10, Qt 5.12.8, Coin 4.0.0, Vtk , OCC 7.6.0
Locale: English/United States (en_US)
Installed mods:
* AnimationFreeCAD 1.0.0
* sheetmetal 0.2.51
* Curves 0.5.2
* Assembly4 0.12.3
* Render 2022.2.0
* fasteners 0.3.50
Re: [Feature Request] Surface finish symbols [SOLVED]
I made a script that regex's the snap package info and xrefs with FreeCAD git HEAD and outputs what commits didn't make it in to the version you're locally running. See Snap#Advanced
Edit: off-topic but I've created a script that figures out the commit hash based on the revision number and then lists all pending commits that aren't in local build. See https://gist.github.com/luzpaz/d0d3d2f6 ... abe427fc9b
Edit: only tested in Snap package.
Code: Select all
$ snap info freecad |grep -e '^\s\+latest/edge' |awk -F ' ' '{ print $2 }' |xargs -I{} git log --oneline --ancestry-path {}..HEAD
b43784c6e2 (HEAD -> master, upstream/master) Gui: [skip ci] mkae sure the tooltip in ActionGroup::onActivated() disappears again
54ce3d0fc3 [TD]fix redraw does not paint all views
0805d284d5 [TD]fix Symbol update on property change
91cffca077 App: use namespace prefix for classes in Base
76aeaab4b0 Arch: added ExclusionNames property to Shape2DViews
9ad8486a25 Base: replace C macro with function and lambda expressions
eccf4fed96 Base: Clean up code and improve docstrings in Python Console module
c14347ce41 * [.github] extend cpplintFilters with -readability/todo
Edit: only tested in Snap package.
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
- tobiasfalk
- Posts: 93
- Joined: Fri Feb 05, 2021 2:35 pm
Re: [Feature Request] Surface finish symbols [SOLVED]
I know this script is practically finished, but first I Found out that only the text of the RA number is made as FreeCAD object(not true also made as SVG text, after trying again it was a mistake and I believed it was selected but something other was) and everything else as SVG text, this brings with it, that the font and its size is not right and that if exported that the text is not markable(not exported as text just like the template, https://forum.freecadweb.org/viewtopic.php?f=35&t=69791) so I wanted to as if it would be possible to change these lite details?
The next thing is that, in the folder with the Sympols you have the following Symbol:
(https://github.com/FreeCAD/FreeCAD/blob ... eneral.svg)
And in one of the drawing I got in Scholl a similar symbol was displayed: Lastly I wanted to know if it would be posible to change the lines of the Symbols, from separate to one line. This is because if not drawen in one go gaps will appear:
The next thing is that, in the folder with the Sympols you have the following Symbol:
(https://github.com/FreeCAD/FreeCAD/blob ... eneral.svg)
And in one of the drawing I got in Scholl a similar symbol was displayed: Lastly I wanted to know if it would be posible to change the lines of the Symbols, from separate to one line. This is because if not drawen in one go gaps will appear:
- Text of Symbols as FreeCAD object?
- More Symbols?
- Gabs in the Symbol
Last edited by tobiasfalk on Fri Jul 29, 2022 12:15 am, edited 1 time in total.
- Shalmeneser
- Veteran
- Posts: 9560
- Joined: Wed Dec 23, 2020 12:04 am
- Location: Fr
Re: [Feature Request] Surface finish symbols [SOLVED]
Try round cap.
- Attachments
-
- Capture d’écran 2022-07-29 013005.jpg (38.57 KiB) Viewed 1406 times
Re: [Feature Request] Surface finish symbols [SOLVED]
This is programmed. But yes, there are a few things, that should be changed.
Greetings
user1234
- wandererfan
- Veteran
- Posts: 6317
- Joined: Tue Nov 06, 2012 5:42 pm
- Contact:
Re: [Feature Request] Surface finish symbols [SOLVED]
The fix for the gaps in the lines is easy (add (stroke-linecap="round" in SvgString::addLine). If nobody beats me to it, I'll do this when I get a minute.tobiasfalk wrote: ↑Thu Jul 28, 2022 10:16 pm Lastly I wanted to know if it would be posible to change the lines of the Symbols, from separate to one line. This is because if not drawen in one go gaps will appear:
From a quick look at the code, all the text seems to be created the same way. We probably need to hear from @edi or maybe @bensay.
When editing an exported PDF, is the text from an annotation "markable"? (I don't remember the last time I tried to modify a PDF)