[BUG] Python Console > Clicking the panel leads to the bottom of the scrollable panel

Post here for help on using FreeCAD's graphical user interface (GUI).
Forum rules
and Helpful information
IMPORTANT: Please click here and read this first, before asking for help

Also, be nice to others! Read the FreeCAD code of conduct!
wmayer
Founder
Posts: 20309
Joined: Thu Feb 19, 2009 10:32 am
Contact:

Re: [BUG] Python Console > Clicking the panel leads to the bottom of the scrollable panel

Post by wmayer »

openBrain wrote: Wed Oct 05, 2022 9:59 am
wmayer wrote: Tue Oct 04, 2022 2:44 pm Can you open a new ticket, please?
Can even do a PR. But what would be your preferred solution ? Make this behavior optional (then default one or not) or just remove it ? Thx
I don't mind if selecting a word or line is possible with a single/double click. The only important point is that it must be impossible to modify the already executed Python code, i.e. everything that is above the lowest line.

It's probably best to make it optional because otherwise it would mean to revert the previous changes.
openBrain
Veteran
Posts: 9041
Joined: Fri Nov 09, 2018 5:38 pm
Contact:

Re: [BUG] Python Console > Clicking the panel leads to the bottom of the scrollable panel

Post by openBrain »

wmayer wrote: Wed Oct 05, 2022 11:21 am I don't mind if selecting a word or line is possible with a single/double click. The only important point is that it must be impossible to modify the already executed Python code, i.e. everything that is above the lowest line.
This already covered by https://github.com/FreeCAD/FreeCAD/blob ... #L551-L573 ;)
It's probably best to make it optional because otherwise it would mean to revert the previous changes.
The old commit that introduced that also contains other changes.
Seriously, I don't see any benefit in this behavior and would just remove it. But it's not a problem to make it optional if you really want. You decide. :)
wmayer
Founder
Posts: 20309
Joined: Thu Feb 19, 2009 10:32 am
Contact:

Re: [BUG] Python Console > Clicking the panel leads to the bottom of the scrollable panel

Post by wmayer »

openBrain wrote: Wed Oct 12, 2022 12:35 pm Seriously, I don't see any benefit in this behavior and would just remove it. But it's not a problem to make it optional if you really want. You decide
I personally don't insist on the current behaviour. So, we can also remove it and in case somebody cries we could still add an option later.
openBrain
Veteran
Posts: 9041
Joined: Fri Nov 09, 2018 5:38 pm
Contact:

Re: [BUG] Python Console > Clicking the panel leads to the bottom of the scrollable panel

Post by openBrain »

leoheck wrote: Mon Oct 03, 2022 7:03 pm This behavior is a bit annoying.
PR is merged.
leoheck
Veteran
Posts: 1225
Joined: Tue Mar 13, 2018 5:56 pm
Location: Coffee shop

Re: [BUG] Python Console > Clicking the panel leads to the bottom of the scrollable panel

Post by leoheck »

That's awesome, I am eager to test. Thanks for all the effort.
leoheck
Veteran
Posts: 1225
Joined: Tue Mar 13, 2018 5:56 pm
Location: Coffee shop

Re: [BUG] Python Console > Clicking the panel leads to the bottom of the scrollable panel

Post by leoheck »

Just confirming I could observe this fix in version 0.21.30780 (Git) Snap 398
The behavior is natural now. It works are any other console. Thanks.

Code: Select all

OS: Ubuntu Core 20 (ubuntu:GNOME/ubuntu)
Word size of FreeCAD: 64-bit
Version: 0.21.30780 (Git) Snap 398
Build type: Release
Branch: master
Hash: b2eb67e8062189ed737b74c98fdbc0989735ab3a
Python 3.8.10, Qt 5.15.5, Coin 4.0.0, Vtk 7.1.1, OCC 7.6.3
Locale: English/United States (en_US)
Installed mods: 
  * Assembly4 0.12.4
but not yet in the AppImage version 0.21.30769 (Git) AppImage

Code: Select all

OS: Ubuntu 22.04.1 LTS (ubuntu:GNOME/ubuntu)
Word size of FreeCAD: 64-bit
Version: 0.21.30769 (Git) AppImage
Build type: Release
Branch: master
Hash: 1282fdb7e8a721e9b411358d68daf8921b0bf50a
Python 3.10.6, Qt 5.15.4, Coin 4.0.0, Vtk 9.1.0, OCC 7.6.3
Locale: English/United States (en_US)
Installed mods: 
  * Defeaturing 1.2.0
  * A2plus 0.4.59c
  * Curves 0.5.8
  * fasteners 0.4.12
  * lattice2 1.0.0
  * Assembly4 0.12.4
  * kicadStepUpMod 10.15.1
  * Help 1.0.3
Post Reply