[implemented] [PartDesign] Fix missing expression binding in primitives placement dialog

[uwestoehr]

I think the dialog for additive/subtractive geometries has a bug:

- open the attached file. You can see that the radius of both spheres is set to the value in the spreadsheet
- now edit the subtractive or additive sphere
- in the appearing dialog you can change the radius. Do this by using the spin buttons.

result: the dialog shows you the value you set, e.g. 12mm. But after finishing the dialog the radius is correctly the one of the spreadsheet.

I think the fix is that the radius value field in the editing dialog gets the formula button as available e.g. for the attachment position fields:

screenshot

Primitive-Dialog-issue.png (32.23 KiB) Viewed 2042 times

[openBrain]

Yep, this missing ability is known and listed by chrisb in this thread
What I don't know is if he still wants to create a ticket before end of 0.19 release. Let's ask :

Ping

[uwestoehr]

Yep, this missing ability is known and listed by chrisb in this thread

Wow your memory is amazing! I commented in ChrisB's thread as well. Since nobody reacted to ChrisB's post I gues the devs are simply not aware of it. So as it is straight forwards. I can act and open a bug report. I'll wait for Chris.

[openBrain]

Wow your memory is amazing! I commented in ChrisB's thread as well. Since nobody reacted to ChrisB's post I gues the devs are simply not aware of it. So as it is straight forwards. I can act and open a bug report. I'll wait for Chris.

I think chrisb's idea to first merge all places where expressions are missing, then open only one ticket, is the way to go.

[chrisb]

Hi guys, thanks for waiting. I will recheck after DeepSOIC's comment and then open a ticket with improved specification for placement expressions.

[chrisb]

issue #3981.

[uwestoehr]

This is fixed with PR: https://github.com/FreeCAD/FreeCAD/pull/3225

[chrisb]

If I see it right, you fixed all of these: https://forum.freecadweb.org/viewtopic.php?f=3&t=33817.
Thanks!

[openBrain]

If I see it right, you fixed all of these: https://forum.freecadweb.org/viewtopic.php?f=3&t=33817.
Thanks!

No, only the 2nd bullet of the OP list of your thread is fixed. Could you strike it ?
Basically what @uwestoehr pointed in the picture in the OP of this thread.

This is fixed with PR: https://github.com/FreeCAD/FreeCAD/pull/3225

Good job. However would it be possible that you amend the commit message so :

• It is a bit self-explanatory. Something like "[PartDesign] Fix missing expression binding in PartDesign primitives placement dialog"
• Change links to ticket so it conforms to what Source Integration expects. Something like "Partially fixing bug #3981"

[chrisb]

No, only the 2nd bullet of the OP list of your thread is fixed. Could you strike it ?

Striking is done. I was mislead, by the plethora of changes and didn't realize that the 2nd bullet described multiple missing expression awarenesses.

Thanks nevertheless to Uwe.