[BUG] crash on Arch material if two materials with the same material name are created

[bernd]

Just run the following code ... bang ... crash

Code: Select all

doc = App.newDocument("MyDoc")
import Arch
matobj1 = Arch.makeMaterial("MyObjectName1")
matobj1.Material = {"Name": "MyMaterialName", "DiffuseColor": "(0.0, 1.0, 0.0, 0)"}
matobj2 = Arch.makeMaterial("MyObjectName2")
matobj2.Material = {"Name": "MyMaterialName", "DiffuseColor": "(0.0, 1.0, 1.0, 0)"}

OS: Debian GNU/Linux 10 (buster) (KDE//usr/share/xsessions/plasma)
Word size of FreeCAD: 64-bit
Version: 0.20.26232 (Git)
Build type: Unknown
Branch: master
Hash: cd8ce95f53d4bf95d906912d8a93665b47cd592f
Python version: 3.7.3
Qt version: 5.11.3
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: German/Switzerland (de_CH)

[bernd]

The crash only happens if in Preferences the following is deactivated:
General --> Document --> Allow duplicate object labels in one document

[Roy_043]

No problem here:

Code: Select all

OS: Windows 8.1 (6.3)
Word size of FreeCAD: 64-bit
Version: 0.20.26201 (Git)
Build type: Release
Branch: master
Hash: 9f2dd4a363053e87e1b1def0d005ed441d378796
Python version: 3.8.12
Qt version: 5.12.9
Coin version: 4.0.0
OCC version: 7.5.3
Locale: Dutch/Netherlands (nl_NL)

[bernd]

are you sure you deactivated the preference? See my second post.

[Roy_043]

Yes. Just check my file. The 2nd material has not received the "MyMaterialName" name.

[bernd]

That is the problem why you get no crash. Did you run the Python code to create this file?

another file attached.

- open the file
- double click on MyMaterialName1
- The Arch Material task panel opens
- delete the "1" in Name ("MyMaterialName")
- click ok

- if duplicate labels are allowed in prefs it works if not crash ...

material-test_2.FCStd

(4.43 KiB) Downloaded 29 times

[Roy_043]

That is the problem why you get no crash. Did you run the Python code to create this file?

Yes.

- if duplicate labels are allowed in prefs it works if not crash ...

Confirmed.

[bernd]

Does it mean it crashs for you with my provided file and workflow but not with the Python code?

If yes ... Strange ... Would you try the Python code once again ?

[bernd]

The problem is the onChanged method of the ArchMaterial.

it takes the Name from the Material dictionary and sets it to the object label, than FreeCAD changes the object label because they should not be equal, thus onChanged is called and sets again the object label. This results in an Endlesloop.

To be honest I do not like the idea to make FreeCAD reset object labels. Even if the user changes the label the label is reset. I do not know any other object ATM who does this.

bernd

[Roy_043]

Regarding the code: I now understand the confusion.

If I run the code by pasting it in the Python console there is no problem. But running the code with Std_DlgMacroExecuteDirect does produce a crash.