Several task panel issues

[Roy_043]

Just reporting...

Point input

1. I think it would make sense to always allow polar coordinates.
2. The "Enter point" button appears above the angle and length fields. This suggests that this button should not be used when entering polar coordinates.
3. Point input for some commands is non-standard: Draft_ShapeString f.e.
4. In the case of some array commands clicking a point will finish the command. This is also non-standard behavior.

Draft_Line

1. Undo button has no purpose. Also reported here: https://forum.freecadweb.org/viewtopic.php?f=23&t=57307 Fixed #5223.

Draft_Arc

1. Relative toggle has no purpose. Fixed #5223.

Draft_Arc_3Points

1. Wrong title and icon ("Point"). Fixed #5250.
2. Continue toggle missing. Fixed #5250.

Draft_Circle

1. Wrong title and icon ("Arc"). Fixed.
2. Relative toggle has no purpose. Fixed #5223.
3. Filled toggle missing (since V0.19). Fixed.

Draft_Polygon

1. Relative toggle has no purpose. Fixed #5223.

Draft_Point

1. Relative toggle has no purpose. Fixed #5223.

Draft_Text

1. Relative toggle has no purpose. Fixed #5223.
2. Continue toggle missing on the first task panel. Fixed #5223.
3. Cannot use the "T" shortcut for the Continue toggle on the second task panel. Fixed #5223.

Draft_Label

1. The Label Type dropdown list does not contain all available options. "Label + Position" - "Label + Material" are missing. Fixed #5249.

Draft_Move

1. 'Modify subelements' setting is not stored.

Draft_Rotate

1. Relative toggle has no purpose. Fixed #5384.
2. 'Modify subelements' setting is not stored.

Draft_Scale

1. Relative toggle has no purpose. Fixed #5384.
2. Continue toggle is ignored. Continue mode is unlikely for this command. Toggle removed #5384.
3. Copy toggle on the 1st task panel is ignored. Removed #5384.
4. 'Modify subelements' toggle on the 1st task panel is ignored although the preview suggests otherwise. Interestingly the opposite applies for the toggle on the 2nd task panel: wrong preview, but correct result. Toggle removed from 1st task panel, preview now updates when switching to or from subelement mode (for other modifier command as well) #5384.
5. 'Create a clone' toggle should also be available on the 1st task panel. No longer an issue: all toggles except the Global toggle were removed from the 1st task panel #5384.
6. 2nd task panel has a wrong icon. Fixed #5384.
7. Toggles on the 2nd task panel do not have shortcuts. No longer an issue: all toggles except the Global toggle were removed from the 1st task panel #5384.
8. Checking the 'Uniform scaling' toggle does not make the existing X, Y and Z factors equal. You have to change one of them first. Fixed #5384.
9. 'Working plane orientation' toggle should perhaps be changed to 'Global scale orientation'. This would be more logical as there is a Global toggle on the first task panel.
10. 'Modify subelements' setting is not stored.
11. 'Modify subelements' and 'Create a clone' can both be checked, but that combination makes no sense. Fixed #5384.
12. 'Modify subelements' and 'Copy' cannot be combined. This is possible however for Draft_Move and Draft_Rotate. Fixed #5282 (previous PR).
13. Continue toggle should also be available on the 2nd task panel. No longer an issue: toggle removed from the 1st task panel #5384.
14. Number of decimals for the coordinates of the point is determined by Edit > Preferences > General > Units > Number of decimals. Number of decimals for the scale factors is determined by Edit > Preferences > Draft > Internal precision level. Fixed #5384.
15. The Close button on the 1st task panel has the same function as the Cancel button on the 2nd panel.

Draft_Mirror

1. Continue toggle has no purpose. Fixed #5384.
2. 'Modify subelements' toggle has no purpose. Fixed #5384.

Draft_Stretch

1. Filled toggle has no purpose. Fixed #5384.
2. Continue toggle has no purpose. Fixed #5384.

Draft_Edit

1. The 2nd Close button (with the icon) on the 1st task panel is strange. It only works if a single Draft Wire is selected. Fixed #7527.
2. The 2nd task panel (displayed if a node is moved) has a wrong title and icon ("Line"). Fixed #7527.
3. Relative toggle on the 2nd task panel has no purpose. Fixed #7541.
4. Continue toggle on the 2nd task panel has no purpose. Fixed #7541.
5. Undo button on the 2nd task panel has no purpose. Fixed #5223.

Code: Select all

OS: Windows 8.1 Version 6.3 (Build 9600)
Word size of FreeCAD: 64-bit
Version: 0.20.24893 (Git)
Build type: Release
Branch: master
Hash: 03855f793feaceeb4385c02f6520f3e1b6429c93
Python version: 3.8.6+
Qt version: 5.15.2
Coin version: 4.0.1
OCC version: 7.5.0
Locale: Dutch/Netherlands (nl_NL)

[bitacovir]

Draft_Arc_3Points

1. Wrong title and icon ("Point").

In Arch workbench there are other task panels with Point object icon for Arch Wall, Arch structure, Arch windows

[Roy_043]

As I understand it the same task panel is being used for multiple commands. In a way this makes sense. But it can also lead to confusion.

[Roy_043]

I have added Draft_Polygon to the OP.

[Roy_043]

I have added Draft_Point to the OP.

[Roy_043]

I have added Draft_text to the OP.

[Roy_043]

I have added Draft_Label to the OP.

[Roy_043]

I have added 3 more commands to the OP.
I also notice that some reported issues have meanwhile been fixed. Thanks for that.

[paullee]

Thanks for looking after lots of features in Draft WB

[Roy_043]

I have added some more stuff to the OP.