asm3 spamming report window when dragging a Part to Assy [SOLVED]

Discussion about the development of the Assembly workbench.
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Post Reply
User avatar
freman
Veteran
Posts: 2201
Joined: Tue Nov 27, 2018 10:30 pm

asm3 spamming report window when dragging a Part to Assy [SOLVED]

Post by freman »

Hi,

just came back to asm3 on master and dragging a Part into the Assembly object in comboview is spamming console and reportview with traceback errors.

It seems that every time the drap op passes over a target where it cannot drop , instead of just changing the cursor it is making a mess.

Someone may need to look at this.

Cheers.

Code: Select all

Traceback (most recent call last):                                                                                                                       
  File "~/.FreeCAD/Mod/FreeCAD_assembly3/freecad/asm3/assembly.py", line 4605, in canDropObjectEx                                               
    return partGroup.canDropObject(obj,owner,subname)                                                                                                    
<class 'TypeError'>: argument 2 must be App.DocumentObject, not None                                                                                     
Traceback (most recent call last):                                                                                                                       
  File "~/.FreeCAD/Mod/FreeCAD_assembly3/freecad/asm3/assembly.py", line 4605, in canDropObjectEx                                               
    return partGroup.canDropObject(obj,owner,subname)                                                                                                    
<class 'TypeError'>: argument 2 must be App.DocumentObject, not None                                                                                     
Traceback (most recent call last):                                                                                                                       
  File "~/.FreeCAD/Mod/FreeCAD_assembly3/freecad/asm3/assembly.py", line 4605, in canDropObjectEx                                               
    return partGroup.canDropObject(obj,owner,subname)                                                                                                    
<class 'TypeError'>: argument 2 must be App.DocumentObject, not None                                                                                     
Traceback (most recent call last):                                                                                                                       
  File "~/.FreeCAD/Mod/FreeCAD_assembly3/freecad/asm3/assembly.py", line 4605, in canDropObjectEx                                               
    return partGroup.canDropObject(obj,owner,subname)                                                                                                    
<class 'TypeError'>: argument 2 must be App.DocumentObject, not None           

Code: Select all

OS: Fedora Linux 35 (Thirty Five) (LXQt//usr/share/xsessions/lxqt)
Word size of FreeCAD: 64-bit
Version: 0.21.30265 (Git)
Build type: Release
Branch: master
Hash: c35244e74f326a04c5bcab31e984742db582ac78
Python 3.10.6, Qt 5.15.2, Coin 4.0.0, Vtk 9.0.3, OCC 7.5.0
Locale: English/United Kingdom (en_GB)
Installed mods: 
  * FreeCAD_Assembly4 0.11.10
  * FreeCAD_assembly3
[EDIT] solution was to update asm3 in ~/.FreeCAD/MOD to use asm3 master. This issue was fixed in March by RealThunder but apparently PRs to FreeCAD have not yet been applied.
Last edited by freman on Tue Sep 20, 2022 8:05 pm, edited 2 times in total.
User avatar
onekk
Veteran
Posts: 6146
Joined: Sat Jan 17, 2015 7:48 am
Contact:

Re: asm3 spamming report window when dragging a Part to Assy

Post by onekk »

freman wrote: Tue Sep 20, 2022 6:52 am ...
Probably posting in the dedicated thread you will receive more "focused answers".

https://forum.freecadweb.org/viewforum.php?f=44


EDIT: This affirmation is wrong, for asm3 related problem the right place to post question is HERE

Regards

Carlo D.
Last edited by onekk on Wed Sep 21, 2022 5:06 pm, edited 2 times in total.
GitHub page: https://github.com/onekk/freecad-doc.
- In deep articles on FreeCAD.
- Learning how to model with scripting.
- Various other stuffs.

Blog: https://okkmkblog.wordpress.com/
User avatar
freman
Veteran
Posts: 2201
Joined: Tue Nov 27, 2018 10:30 pm

Re: asm3 spamming report window when dragging a Part to Assy

Post by freman »

Looks like my asm3 was about 6mo old. I've updated.
marioalexis
Posts: 124
Joined: Wed Jun 19, 2019 7:44 pm

Re: asm3 spamming report window when dragging a Part to Assy

Post by marioalexis »

There are two pull request to fix this waiting to be merged in FreeCAD-0-20 and master, respectively
User avatar
freman
Veteran
Posts: 2201
Joined: Tue Nov 27, 2018 10:30 pm

Re: asm3 spamming report window when dragging a Part to Assy

Post by freman »

Thanks for the info. So where is the FreeCAD version of this ? I don't see it in the master tree. Does the addons manager pull it in from somewhere else but not the upto date asm3 master?

thx
User avatar
adrianinsaval
Veteran
Posts: 5541
Joined: Thu Apr 05, 2018 5:15 pm

Re: asm3 spamming report window when dragging a Part to Assy [SOLVED]

Post by adrianinsaval »

the addon manager pulls from asm3 source: https://github.com/realthunder/FreeCAD_assembly3
it is not integrated in master branch and it is not expected to be integrated due to license conflict
User avatar
freman
Veteran
Posts: 2201
Joined: Tue Nov 27, 2018 10:30 pm

Re: asm3 spamming report window when dragging a Part to Assy

Post by freman »

marioalexis wrote: Tue Sep 20, 2022 4:10 pm There are two pull request to fix this waiting to be merged in FreeCAD-0-20 and master, respectively
I don't understand this comment. If FreeCAD pulls in from assembly3 master, why does FC need a patch at all?

Can you provide a PR number or a link?

Thanks.
marioalexis
Posts: 124
Joined: Wed Jun 19, 2019 7:44 pm

Re: asm3 spamming report window when dragging a Part to Assy [SOLVED]

Post by marioalexis »

The error is due to a regression in the master branch.
This pull request fixes the error in FreeCAD-0.20: 7507.
And this in current master 7236
User avatar
freman
Veteran
Posts: 2201
Joined: Tue Nov 27, 2018 10:30 pm

Re: asm3 spamming report window when dragging a Part to Assy [SOLVED]

Post by freman »

Thanks for rebasing, hopefully it will get merged this time. That affected a ton of files. Thanks for the effort.
Post Reply