Visibility issues with PD Pipes

[jnxd]

Steps to reproduce:

1. With the attached file start additive pipe with SketchBase for profile.
2. Set SketchPath as path.
3. In section transformation select "Multisection" and add Sketch001 and Sketch002.

After the sweep is made, Sketch001 and Sketch002 are still visible. Further, after undoing, or deleting the sweep, SketchBase becomes visible again, but SketchPath does not.

I don't know if keeping the sections is intended behavior, but the second visibility issue is definitely a bug.

[EDIT] Version details:

Code: Select all

OS: Ubuntu 20.04.3 LTS (MATE/mate)
Word size of FreeCAD: 64-bit
Version: 0.20.26316 (Git)
Build type: Unknown
Branch: (HEAD detached at donovaly/PD-loft-visibility-fix)
Hash: fc608c12acc27451960f00f3cb6f91da0b07df76
Python version: 3.8.10
Qt version: 5.12.8
Coin version: 4.0.0
OCC version: 7.5.2
Locale: English/United States (en_US)

[chrisb]

Does this occur in master as well (no opportunity to test myself now).

[jnxd]

Does this occur in master as well (no opportunity to test myself now).

Yes. The branch I posted was just one commit ahead, and that commit only changed loft.

[jonasb]

This sounds similar to this discussion here: https://forum.freecadweb.org/viewtopic.php?f=10&t=63531

[chrisb]

I can confirm the issues. It was the same in 0.19.

[uwestoehr]

After the sweep is made, Sketch001 and Sketch002 are still visible.

Yes, in the code only the spine and base are made invisible. I agree that all should consistently become invisible since this is also the case for e.g. lofts and who needs to have them visible can do so.

Further, after undoing, or deleting the sweep, SketchBase becomes visible again, but SketchPath does not.

I cannot reproduce this. Here the sketch visibility is kept as it is, SketchBase stays invisible:

neKq7P6KUb.gif (14.74 KiB) Viewed 4368 times

[uwestoehr]

Here is a PR that should fix the visibility issue: https://github.com/FreeCAD/FreeCAD/pull/5158

Now the profile is treated like the path. I also changed it so that the sections are hidden on closing the pipe.

When deleting the visibility of underlying objects is kept untouched.

With this PR the visibility is now also consistent to lofts.

[chennes]

PR 5163 (the replacement for 5158) is now merged. Note that it does not address the Undo issue -- if you haven't already, could someone please post a tracker ticket for that?

[uwestoehr]

PR 5163 (the replacement for 5158) is now merged. Note that it does not address the Undo issue -- if you haven't already, could someone please post a tracker ticket for that?

@wmayer kindly already fixed it: git commit fb9a3eecff182a9