Darned newbies... Created my first PR (6783) and initially it was locked (as are all first posts). The lock appears to have been lifted. Thanks!
BUT, after lodging that firt PR, and without understanding the locking thing, I also lodged another. Well I think I did it right. Anyway, there is no sign of it. Would it be right to assume it got eaten?
Just re-lodge?
EDIT: "1 workflow awaiting approval" is still in that state. Thought it had gone.
PR eaten, maybe
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Be nice to others! Respect the FreeCAD code of conduct!
-
- Posts: 176
- Joined: Wed Mar 09, 2022 3:15 am
- Location: Oz
PR eaten, maybe
Last edited by FreddyFreddy on Mon Apr 25, 2022 4:50 pm, edited 1 time in total.
- adrianinsaval
- Veteran
- Posts: 5551
- Joined: Thu Apr 05, 2018 5:15 pm
Re: PR eaten, maybe
what is locking in your mind? do you mean closed? I see one closed and one open PR from you:
https://github.com/FreeCAD/FreeCAD/pull ... s%3Aclosed
if you intended to create a third PR, maybe you didn't finish the creation process
https://github.com/FreeCAD/FreeCAD/pull ... s%3Aclosed
if you intended to create a third PR, maybe you didn't finish the creation process
-
- Posts: 176
- Joined: Wed Mar 09, 2022 3:15 am
- Location: Oz
Re: PR eaten, maybe
No, the closed PR was a first (bad) attempt, so I bailed out almost immediately to spare embarrassment. So not counting that one.adrianinsaval wrote: ↑Mon Apr 25, 2022 3:59 pm what is locking in your mind? do you mean closed? I see one closed and one open PR from you:
https://github.com/FreeCAD/FreeCAD/pull ... s%3Aclosed
if you intended to create a third PR, maybe you didn't finish the creation process
By 'locking' I refer to the process whereby a first PR from a user is held pending approval to proceed, and blocks further PRs, to prevent spurious unwanted PRs being processed. Forgive me I can't remember exactly the words.
So I'm wondering if another PR lodged during the lock period gets eaten, ignored, whatever. Pretty sure I lodged correctly. I'm reluctant to rush in and lodge again in case the blocked one magically reappears.
EDIT I guess wait a day and relodge.
Re: PR eaten, maybe
I don't know if the CI system is blocking you, but I went ahead and triggered the CI run on your Clang formatting PR, we'll see if that clears up the issue.
-
- Posts: 6
- Joined: Sat Oct 10, 2020 9:36 pm
Re: PR eaten, maybe
If you mean this:
It only prevents the automatic CI run (in this case the spell checker run) for first-time contributors. (See: https://github.blog/2021-04-22-github-a ... ad-actors/ ).
This is a Github thing:It only prevents the automatic CI run (in this case the spell checker run) for first-time contributors. (See: https://github.blog/2021-04-22-github-a ... ad-actors/ ).
-
- Posts: 176
- Joined: Wed Mar 09, 2022 3:15 am
- Location: Oz
- adrianinsaval
- Veteran
- Posts: 5551
- Joined: Thu Apr 05, 2018 5:15 pm
Re: PR eaten, maybe
So I'm a little confused, you want to submit a PR different from https://github.com/FreeCAD/FreeCAD/pull/6783 ? If by locked you mean the status of the checks:
these shouldn't block anything, it's possible to merge PRs that fail some test, although not always advisable. It also doesn't block pushing changes to that PR or submitting other PRs.
Anyways, IMO you should just go ahead and try again submitting your PR, worst case scenario you'll have to close a duplicate.
Anyways, IMO you should just go ahead and try again submitting your PR, worst case scenario you'll have to close a duplicate.
-
- Posts: 176
- Joined: Wed Mar 09, 2022 3:15 am
- Location: Oz
Re: PR eaten, maybe
Apologies to the community if I am unnecessarily wasting resources by bailing out of PRs and starting again when I lose the plot.