Plot and Ship modules have not been working for a long time, so I decided to fix them! (after some people pushed me to do that )
https://github.com/FreeCAD/FreeCAD/pull/4870
The code would really enjoy several improvements, but I really think is good enough to get the modules online again
Plot and Ship
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Be nice to others! Respect the FreeCAD code of conduct!
-
- Posts: 60
- Joined: Wed Jan 01, 2014 1:17 pm
Re: Plot and Ship
Ship as default on? I do not like that. I also think that the ship workbench is too specific, only my two cents.
Greetings
user1234
Greetings
user1234
Re: Plot and Ship
Great work @Sanguinario_Joe! Good to have the workbenches fixed.
Following user1234 observation, which are the pros to you on having them inside the core FreeCAD rather than distributing them as external modules? I'm asking cause they seems 100% python
Following user1234 observation, which are the pros to you on having them inside the core FreeCAD rather than distributing them as external modules? I'm asking cause they seems 100% python
follow my experiments on BIM modelling for architecture design
-
- Posts: 60
- Joined: Wed Jan 01, 2014 1:17 pm
Re: Plot and Ship
Some years ago someone already asked that, and I already voted to move them out. But I came back and saw them inside the main source code tree, so I was thinking they finally decided to keep them.
@luzpaz added a note in the PR heading me to the right place. I am thus fixing the modules there, and editing the PR to remove any trace to Plot and Ship from the main repo.
@luzpaz added a note in the PR heading me to the right place. I am thus fixing the modules there, and editing the PR to remove any trace to Plot and Ship from the main repo.
-
- Posts: 60
- Joined: Wed Jan 01, 2014 1:17 pm
Re: Plot and Ship
Done, the correct PRs are submitted to https://github.com/FreeCAD/freecad.ship and https://github.com/FreeCAD/freecad.plot. Now the PR to the main source tree is actually removing those modules