Issue 0002284 (part 1): No error shown in unsolved sketch

Merged, abandoned or rejected pull requests are moved here to clear the main Pull Requests forum.
Post Reply
abdullah
Veteran
Posts: 4935
Joined: Sun May 04, 2014 3:16 pm
Contact:

Issue 0002284 (part 1): No error shown in unsolved sketch

Post by abdullah »

I request the merge of this branch:
https://github.com/abdullahtahiriyo/Fre ... ue_0002284

Discussion here (see screenshot):
viewtopic.php?f=19&t=12571

Please do not close the ticket. That ticket should be tagged as "solver issues", so that we revisit it when we improve the solvers (some mantis could assist me here. I do not know how to create tags.).

What is this?

When the solver converged (but did not succeed) or when the solver succeded but the solution is not OCC-valid, no error message was shown in the solver messages dialog. This fixes that and increases the emphasis of the solver result by making the text red if unsolved or green if solved.

EDIT: I managed to add the tag "solver". I missed a quite big control to add tags repeatedly (gotta get glasses!).
wmayer
Founder
Posts: 20113
Joined: Thu Feb 19, 2009 10:32 am
Contact:

Re: Issue 0002284 (part 1): No error shown in unsolved sketch

Post by wmayer »

Merged.
Post Reply