Turning Addon PathOpGui.py

Post here if you have re-based and finalised code to integrate into master, which was discussed, agreed to and tested in other forums. You can also submit your PR directly on github.
Post Reply
WarrenkCash
Posts: 19
Joined: Wed Aug 04, 2021 9:10 am

Turning Addon PathOpGui.py

Post by WarrenkCash »

I edited PathOpGui.py as it was not allowing me to create lath paths with the turning addon. I was asked to create a pull request.

After a couple of hours of reaserch I think the pull request is done. I created a fork of freecad and changed PathOpGui.py .

Origional

Code: Select all

 obj = res.objFactory(res.name, obj=None, parentJob=res.job)
edited

Code: Select all

obj = res.objFactory(res.name, obj=None)


I created a pull request and had an option to merge as it didn't affect anything in the main branch or something like.So I clicked it and got this message on completion.

Pull request successfully merged and closed

You’re all set—the WarrenKCash-patch-1 branch can be safely deleted.

The page is at https://github.com/WarrenKCash/FreeCAD/pull/1

Hopefully this is how it is supposed to work.
Syres
Veteran
Posts: 1715
Joined: Thu Aug 09, 2018 11:14 am

Re: Turning Addon PathOpGui.py

Post by Syres »

WarrenkCash wrote: Thu Jul 28, 2022 8:41 am I created a pull request and had an option to merge as it didn't affect anything in the main branch or something like.So I clicked it and got this message on completion.
It appears you created a Pull Request on your own branch not on the FreeCAD master which you cannot Merge because it would need to be reviewed by others first. If you look at https://github.com/FreeCAD/FreeCAD/comp ... sh-patch-1 you'll see a Create Pull Request green button which will take you through to the next stage.
GeneFC
Veteran
Posts: 3745
Joined: Sat Mar 19, 2016 3:36 pm
Location: Punta Gorda, FL

Re: Turning Addon PathOpGui.py

Post by GeneFC »

Syres wrote: Mon Aug 01, 2022 6:58 pm
This has already been sorted out. See

https://forum.freecadweb.org/viewtopic. ... &start=150

Gene
Post Reply