Best practise?

Here's the place for discussion related to coding in FreeCAD, C++ or Python. Design, interfaces and structures.
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
wmayer
Founder
Posts: 20243
Joined: Thu Feb 19, 2009 10:32 am
Contact:

Re: Best practise?

Post by wmayer »

I stumbled on this code and nearly choked. How could this 1995 style stuff still be in the codebase?
It was part of a PR with more than 600 modified files. I once did the review of this PR and complained about these C macros.
Since that PR was already the second attempt to merge the code I didn't want to delay it further.

Here is the corresponding thread: https://forum.freecadweb.org/viewtopic.php?f=10&t=38970
berniev
Posts: 247
Joined: Wed Apr 13, 2022 10:45 pm
Location: Oz

Re: Best practise?

Post by berniev »

wmayer wrote: Sun Sep 25, 2022 11:19 am
It was part of a PR with more than 600 modified files. I once did the review of this PR and complained about these C macros.
Since that PR was already the second attempt to merge the code I didn't want to delay it further
I hear your pain. What a cluster Fck!
Post Reply