Coding. style

[jnxd]

Mind hopping in with your inputs? Do you recall what the PR was where we talked about it?

https://github.com/FreeCAD/FreeCAD/pull ... r757918354

Thanks! Not even sure how you found it .

I don't see a problem with readability if auto instead of TopoDS_Shape was used because the call of TopoDS::Shell makes it obvious that s must be a TopoDS_Shape

I'm fine either way.

[wmayer]

Thanks! Not even sure how you found it

It's a matter of using the correct filter. The PR is closed, you are the author and donovaly did the review. So, you get this filter

Code: Select all

is:closed is:pr author:AjinkyaDahale mentions:donovaly 

This results into 10 PRs and now you have to go through all of them and check the comments.

[adrianinsaval]

Code: Select all

is:closed is:pr author:AjinkyaDahale mentions:donovaly 

doesn't mentions:donovaly only work if someone writes @donovaly somewhere? I would think commenter:donovaly would be a more complete filter

[adrianinsaval]

Thanks for the support! Will get there soon enough.

Nice, it's good to see new people with this attitude. I would recommend limiting the scope of your changes and submitting a PR to get feedback and know if you're on the right track. It's also easier to get your changes in if it's not a massive PR.

[jnxd]

It's a matter of using the correct filter. The PR is closed, you are the author and donovaly did the review. So, you get this filter

doesn't mentions:donovaly only work if someone writes @donovaly somewhere? I would think commenter:donovaly would be a more complete filter

Thanks for the info, Werner and Adrian.

[FreddyFreddy]

The latter (leading _) I understand is all about not polluting the global space (plenty of that here). Not hard to fix, but might need some concensus on naming convention. Any inputs?

Concrete example?

From https://en.cppreference.com/w/cpp/language/identifiers

A valid identifier must begin with a non-digit character ... exceptions:

the identifiers with a double underscore anywhere are reserved;

the identifiers that begin with an underscore followed by an uppercase letter are reserved;

the identifiers that begin with an underscore are reserved in the global namespace.

"Reserved" here means that the standard library headers #define or declare such identifiers for their internal needs, the compiler may predefine non-standard identifiers of that kind, and that name mangling algorithm may assume that some of these identifiers are not in use. If the programmer uses such identifiers, the behavior is undefined.

Example in exception.cpp

Code: Select all

 'static PyMethodDef* __AppMethods = nullptr;

[FreddyFreddy]

Going back to the original question ...

I have hit a snag. Part of my normal workflow is to occasionally hit the IDE's 'format' to enforce uniform layout and clean up any messes I made. That way there's one thing less to think about when typing.

BUT formatting Application.cpp produced hundreds of changes due to differences between my settings and the freecad code.

I tried to change my settings to match fc, but even within the one fc file there are different styles. Spaces, brackets etc etc etc

Personally I like things to be uniform. But submitting hundreds of changes just to please me is obviously not an option!

Help?!?

[wmayer]

From https://en.cppreference.com/w/cpp/language/identifiers

Thx.

Example in exception.cpp

It's in Application.cpp.

the identifiers with a double underscore anywhere are reserved;
the identifiers that begin with an underscore are reserved in the global namespace.

The easiest is to move the variable into anonymous namespace which is in anyway the preferred way in modern C++.

Code: Select all

namespace {
static PyMethodDef* AppMethods = nullptr;
}

[FreddyFreddy]

Example in exception.cpp

It's in Application.cpp.

Yeah! That one! (Tks)

The easiest is to move the variable into anonymous namespace which is in anyway the preferred way in modern C++.

That sounds easy enough! One for down the track a bit?!

[FreddyFreddy]

Re the format question, maybe cmake-format is a good option.

cmake-format can format your listfiles nicely so that they don’t look like crap.

Seems to work with a bunch of editors/ide's. I think a file is placed in the project root. CLion for example will use it if it is there. It can be initialised from quite a long list of defaults. qt was mentioned here previously. I don't see that listed in cmake doc, but it is one option in CLion.

Is this a known good (or bad) idea?

EDIT: Am confusing myself. The one in CLion is clang-format (part of LLVM project) and seems the most popular.