Expression Completer - Changes, Fixes

Here's the place for discussion related to coding in FreeCAD, C++ or Python. Design, interfaces and structures.
bleber
Posts: 174
Joined: Thu Jun 30, 2016 5:12 pm

Re: Expression Completer - Changes, Fixes

Post by bleber »

acpopescu wrote: Sun Jan 22, 2023 1:21 pm what did you have in mind
A mockup with the process to "catch" a length propriety of an edge.
For maximum flexibility, the reference can ve anything that you can extract a number to assign to an expression to make a formula.
The "another level feature" are make an: if, or, ..... basic programming formulas in the formula editor.
Attachments
Screenshot_20230124_013406.png
Screenshot_20230124_013406.png (122.23 KiB) Viewed 350 times
User avatar
chennes
Veteran
Posts: 2843
Joined: Fri Dec 23, 2016 3:38 pm
Location: Norman, OK, USA
Contact:

Re: Expression Completer - Changes, Fixes

Post by chennes »

Thanks for the PR, and especially for the extended documentation you added to the top of the code -- that makes it much easier to understand what's going on. This is a nice short one, we should be able to get it merged pretty quickly here.
Chris Hennes
Pioneer Library System
GitHub profile, LinkedIn profile, chrishennes.com
User avatar
chennes
Veteran
Posts: 2843
Joined: Fri Dec 23, 2016 3:38 pm
Location: Norman, OK, USA
Contact:

Re: Expression Completer - Changes, Fixes

Post by chennes »

OK, this PR has been merged as of a few minutes ago -- thanks again, @acpopescu.
Chris Hennes
Pioneer Library System
GitHub profile, LinkedIn profile, chrishennes.com
chrisb
Veteran
Posts: 46875
Joined: Tue Mar 17, 2015 9:14 am

Re: Expression Completer - Changes, Fixes

Post by chrisb »

I haven't tested yet, but I guess it works.
This is a good example that it it is sensible to have smaller PRs, even if they don't have in one go the full functionality of the final target. @realthunder, care to take a look? Perhaps the rest of PR3062 (I understand there is a rest?) can be split as well in order to be meged more easily.
A Sketcher Lecture with in-depth information is available in English, auf Deutsch, en français, en español.
Post Reply